Skip to content

refactor(server): remove dead code, tighten types - #210

Merged
buzz-code merged 3 commits into
mainfrom
claude/refactor-tech-debt-2026-10-10
Oct 10, 2026
Merged

buzz-code merged 3 commits into
mainfrom
claude/refactor-tech-debt-2026-10-10

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Scope

Small, behavior-preserving server cleanup. No API, migration, or submodule changes. No helpers added.

  • reports/lessonSignaturePdfReport.tsx: drop unused ReportGroupSession import and unused id destructure.
  • reports/studentReportCardReact.tsx: drop unused emptyCellStyle destructure.
  • db/entities/User.entity.ts: remove commented-out @OneToMany decorators.
  • entity-modules/att-report-with-report-month.config.ts: extra: any -> Record<string, string> in private bulk-action methods.

Considered and skipped: any in student-by-year config (dynamic pivot shape, typing breaks compile); unused vars in old migrations (not to be edited).

Tests

  • Server (yarn test): before 120 suites / 1176 tests pass; after same. tsc --noEmit clean.
  • Client (yarn test): untouched. One transient failure seen once in baseline run, 225/225 pass on rerun.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KwMPwZjUotwT9JTa5g3XgV


Generated by Claude Code

…ghten extra types

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KwMPwZjUotwT9JTa5g3XgV
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KwMPwZjUotwT9JTa5g3XgV
@buzz-code
buzz-code merged commit 138fc3b into main Oct 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants