Skip to content

Add agent skills and roadmap guideline from multi-repo-codespace - #207

Merged
buzz-code merged 2 commits into
mainfrom
claude/epic-brown-krwx3t
Oct 7, 2026
Merged

buzz-code merged 2 commits into
mainfrom
claude/epic-brown-krwx3t

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Copy 13 project-relevant skills from multi-repo-codespace/.github/skills (all except run-one-project, which only wraps the codespace start script).
  • Symlink .claude/skills -> ../.github/skills.
  • AGENTS.md: add guideline 5. Update the Roadmap and a Skills index.
  • Sync .github/copilot-instructions.md with AGENTS.md (was stale, still said never modify shared code).

Docs/skills only; no code changes.

🤖 Generated with Claude Code

https://claude.ai/code/session_012m7WPGj4ePE7vjCiM6yH7b


Generated by Claude Code

claude added 2 commits October 7, 2026 17:53
Copy project-relevant skills from multi-repo-codespace .github/skills
(all except run-one-project, which only wraps the codespace start script),
symlink .claude/skills to them, and add the roadmap guideline and skills
index to AGENTS.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012m7WPGj4ePE7vjCiM6yH7b
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012m7WPGj4ePE7vjCiM6yH7b
Copilot AI balanced review requested due to automatic review settings October 7, 2026 18:09
@buzz-code
buzz-code merged commit 43d8cd7 into main Oct 7, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Several skills contain failing commands, invalid API examples, and unsafe authorization guidance.

18 open findings
What changed in this PR

Adds repository-local agent skills and synchronizes contributor guidance.

Changes:

  • Adds 13 workflow skills.
  • Adds .claude/skills symlink.
  • Syncs roadmap, shared-code, and skill guidance.
File Description
AGENTS.md Adds roadmap and skill guidance
.github/​copilot-instructions.md Syncs Copilot instructions
.claude/​skills Links Claude skill directory
.github/​skills/​add-bulk-action/​SKILL.md Documents bulk actions
.github/​skills/​bump-shared-ref/​SKILL.md Documents submodule bumps
.github/​skills/​debug-project-issues/​SKILL.md Adds debugging workflow
.github/​skills/​find-missing-translations/​SKILL.md Adds translation audit workflow
.github/​skills/​generate-migration/​SKILL.md Adds migration workflow
.github/​skills/​manage-entity/​SKILL.md Documents CRUD entity changes
.github/​skills/​manage-permissions/​SKILL.md Documents permission wiring
.github/​skills/​report-generation/​SKILL.md Documents reports and exports
.github/​skills/​run-without-docker/​SKILL.md Adds local MySQL workflow
.github/​skills/​shared-changes-workflow/​SKILL.md Documents shared change rollout
.github/​skills/​smoke-test-project/​SKILL.md Adds endpoint smoke testing
.github/​skills/​write-tests/​SKILL.md Documents test patterns
.github/​skills/​yemot-integration/​SKILL.md Documents Yemot flows

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

2. **Server** — in `server/src/entity-modules/<entity>.config.ts`:
- Override `doAction(req, body)` on the entity's service class (extend `BaseEntityService`) if not already overridden.
- Add a `case '<name>':` to the `switch (req.parsed.extra.action)` matching the client's `name`.
- Read ids/params via `@shared/utils/queryParam.util` helpers (`getAsNumberArray`, `getAsDate`, `getAsBoolean`) off `req.parsed.extra`.
- Read ids/params via `@shared/utils/queryParam.util` helpers (`getAsNumberArray`, `getAsDate`, `getAsBoolean`) off `req.parsed.extra`.
- Do the work, then `return` a user-facing (Hebrew) result string. Fall through to `super.doAction(req, body)` for unmatched actions.
- If the logic is genuinely reusable across projects, extract it into a util in `server/shared/utils/entity/` (following `fixReference.util.ts`) and call that from the `case`.
3. Restart the project (`bash scripts/start-project.sh <project>`) and verify: select rows in the entity's list, trigger the button, confirm the success/error notification and (if `reloadOnEnd`) the list refresh.

### 6. Verify (only if you made a consumer change)

A pointer-only bump with no row applying to this project needs no separate verification step. When step 2 did require a consumer change, run the relevant test suite (`cd client && yarn test`, `cd server && yarn test`) and, only if the change needs manual/UI checking, start the stack (`run-one-project` skill) and exercise the affected flow.
Comment on lines +53 to +54
docker exec -it <container-name>-database-dev \
mysql -u root -proot <dbname> -e "SELECT * FROM migrations ORDER BY timestamp DESC LIMIT 20;"

| Error | Category | Next action |
|-------|---------|------------|
| 401 on `/auth/login` | Auth | Check `ADMIN_USER`/`ADMIN_PASSWORD` env vars |

Each project's server has a `helpers/endpoints.env` file listing all registered entity endpoints. The shared runner script logs into the backend and calls every endpoint with the authenticated cookie.

**Prerequisite:** The project must be running. Use the `run-one-project` skill first if needed.
Comment on lines +22 to +23
bash scripts/run-client-tests.sh
bash scripts/run-server-tests.sh # run bash setup-node-modules.sh first if modules missing
bash scripts/run-server-tests.sh # run bash setup-node-modules.sh first if modules missing
```

Tests colocate under `__tests__/` next to the code. Shared code is tested in its own repo (`nra-client`, `nra-server`), consumers test only their own project code.

## Common tasks

**Add/change a flow:** edit the project's `YemotHandlerService.processCall()` (and its private `process*Call()` helpers). Ask the user (via `this.read/send` helpers on the base) for input, validate, persist. Keep flow-specific logic in the project; only truly shared IVR mechanics go in `nra-server`.

**Add/change a flow:** edit the project's `YemotHandlerService.processCall()` (and its private `process*Call()` helpers). Ask the user (via `this.read/send` helpers on the base) for input, validate, persist. Keep flow-specific logic in the project; only truly shared IVR mechanics go in `nra-server`.

**Menu texts** live in DB (`YemotCall`/yemot-texts) and are updated via migrations — see the `UpdateYemotTexts*` migrations in `react-admin-nestjs/server/src/migrations/`. Use `generate-migration` for schema/text changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants