Repository navigation
Add agent skills and roadmap guideline from multi-repo-codespace - #207
Merged
Merged
Conversation
Copy project-relevant skills from multi-repo-codespace .github/skills (all except run-one-project, which only wraps the codespace start script), symlink .claude/skills to them, and add the roadmap guideline and skills index to AGENTS.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012m7WPGj4ePE7vjCiM6yH7b
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012m7WPGj4ePE7vjCiM6yH7b
There was a problem hiding this comment.
🟡 Changes recommended
Several skills contain failing commands, invalid API examples, and unsafe authorization guidance.
18 open findings
Enforce permissions and tenant scope before bulk mutation · New Use the documented Docker command for verification · New Replace unavailable run-one-project verification path · New Use the configured MySQL root password · New Use the combined ADMIN_USER configuration · New Clarify scanner location in multi-repo-codespace · New Provide separate Docker and local migration commands · New Use the repository's documented Docker startup command · New Correct the inaccurate client and server map comparison · New Remove redundant shared user component edit · New Pass a configured report generator to the PDF wrapper · New Scope report IDs before loading report data · New Configure ADMIN_USER before login smoke tests · New Reference unavailable run-one-project guidance · New Use workspace-qualified paths for multi-repo scripts · New Correct claims about Jest test discovery · New Use the correct input and message helper APIs · New Use a data migration for menu text inserts · New
What changed in this PR
Adds repository-local agent skills and synchronizes contributor guidance.
Changes:
- Adds 13 workflow skills.
- Adds
.claude/skillssymlink. - Syncs roadmap, shared-code, and skill guidance.
| File | Description |
|---|---|
AGENTS.md |
Adds roadmap and skill guidance |
.github/copilot-instructions.md |
Syncs Copilot instructions |
.claude/skills |
Links Claude skill directory |
.github/skills/add-bulk-action/SKILL.md |
Documents bulk actions |
.github/skills/bump-shared-ref/SKILL.md |
Documents submodule bumps |
.github/skills/debug-project-issues/SKILL.md |
Adds debugging workflow |
.github/skills/find-missing-translations/SKILL.md |
Adds translation audit workflow |
.github/skills/generate-migration/SKILL.md |
Adds migration workflow |
.github/skills/manage-entity/SKILL.md |
Documents CRUD entity changes |
.github/skills/manage-permissions/SKILL.md |
Documents permission wiring |
.github/skills/report-generation/SKILL.md |
Documents reports and exports |
.github/skills/run-without-docker/SKILL.md |
Adds local MySQL workflow |
.github/skills/shared-changes-workflow/SKILL.md |
Documents shared change rollout |
.github/skills/smoke-test-project/SKILL.md |
Adds endpoint smoke testing |
.github/skills/write-tests/SKILL.md |
Documents test patterns |
.github/skills/yemot-integration/SKILL.md |
Documents Yemot flows |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| 2. **Server** — in `server/src/entity-modules/<entity>.config.ts`: | ||
| - Override `doAction(req, body)` on the entity's service class (extend `BaseEntityService`) if not already overridden. | ||
| - Add a `case '<name>':` to the `switch (req.parsed.extra.action)` matching the client's `name`. | ||
| - Read ids/params via `@shared/utils/queryParam.util` helpers (`getAsNumberArray`, `getAsDate`, `getAsBoolean`) off `req.parsed.extra`. |
| - Read ids/params via `@shared/utils/queryParam.util` helpers (`getAsNumberArray`, `getAsDate`, `getAsBoolean`) off `req.parsed.extra`. | ||
| - Do the work, then `return` a user-facing (Hebrew) result string. Fall through to `super.doAction(req, body)` for unmatched actions. | ||
| - If the logic is genuinely reusable across projects, extract it into a util in `server/shared/utils/entity/` (following `fixReference.util.ts`) and call that from the `case`. | ||
| 3. Restart the project (`bash scripts/start-project.sh <project>`) and verify: select rows in the entity's list, trigger the button, confirm the success/error notification and (if `reloadOnEnd`) the list refresh. |
|
|
||
| ### 6. Verify (only if you made a consumer change) | ||
|
|
||
| A pointer-only bump with no row applying to this project needs no separate verification step. When step 2 did require a consumer change, run the relevant test suite (`cd client && yarn test`, `cd server && yarn test`) and, only if the change needs manual/UI checking, start the stack (`run-one-project` skill) and exercise the affected flow. |
Comment on lines
+53
to
+54
| docker exec -it <container-name>-database-dev \ | ||
| mysql -u root -proot <dbname> -e "SELECT * FROM migrations ORDER BY timestamp DESC LIMIT 20;" |
|
|
||
| | Error | Category | Next action | | ||
| |-------|---------|------------| | ||
| | 401 on `/auth/login` | Auth | Check `ADMIN_USER`/`ADMIN_PASSWORD` env vars | |
|
|
||
| Each project's server has a `helpers/endpoints.env` file listing all registered entity endpoints. The shared runner script logs into the backend and calls every endpoint with the authenticated cookie. | ||
|
|
||
| **Prerequisite:** The project must be running. Use the `run-one-project` skill first if needed. |
Comment on lines
+22
to
+23
| bash scripts/run-client-tests.sh | ||
| bash scripts/run-server-tests.sh # run bash setup-node-modules.sh first if modules missing |
| bash scripts/run-server-tests.sh # run bash setup-node-modules.sh first if modules missing | ||
| ``` | ||
|
|
||
| Tests colocate under `__tests__/` next to the code. Shared code is tested in its own repo (`nra-client`, `nra-server`), consumers test only their own project code. |
|
|
||
| ## Common tasks | ||
|
|
||
| **Add/change a flow:** edit the project's `YemotHandlerService.processCall()` (and its private `process*Call()` helpers). Ask the user (via `this.read/send` helpers on the base) for input, validate, persist. Keep flow-specific logic in the project; only truly shared IVR mechanics go in `nra-server`. |
|
|
||
| **Add/change a flow:** edit the project's `YemotHandlerService.processCall()` (and its private `process*Call()` helpers). Ask the user (via `this.read/send` helpers on the base) for input, validate, persist. Keep flow-specific logic in the project; only truly shared IVR mechanics go in `nra-server`. | ||
|
|
||
| **Menu texts** live in DB (`YemotCall`/yemot-texts) and are updated via migrations — see the `UpdateYemotTexts*` migrations in `react-admin-nestjs/server/src/migrations/`. Use `generate-migration` for schema/text changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
multi-repo-codespace/.github/skills(all exceptrun-one-project, which only wraps the codespace start script)..claude/skills->../.github/skills.AGENTS.md: add guideline 5. Update the Roadmap and a Skills index..github/copilot-instructions.mdwithAGENTS.md(was stale, still said never modify shared code).Docs/skills only; no code changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_012m7WPGj4ePE7vjCiM6yH7b
Generated by Claude Code