Repository navigation
Teacher reported today: click missing count to show the girls' names - #206
Merged
Merged
Conversation
Names are fetched only on click, from att_report rows of that lesson (same teacher, class, subject and date, absCount > 0), created from the lesson's first report up to the next lesson of the same subject. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
There was a problem hiding this comment.
🟡 Changes recommended
Pagination limits and null IDs can produce incomplete or incorrect name lists.
1 open finding
What changed in this PR
Adds clickable missing-girl counts with on-demand name popovers.
Changes:
- Queries attendance records for selected lesson window.
- Adds completed roadmap entry.
| File | Description |
|---|---|
client/src/entities/teacher-reported-today.jsx |
Adds missing-girl popover and queries. |
client/src/roadmapFeatures.js |
Records feature completion. |
Files not reviewed (1)
- client/src/roadmapFeatures.js: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
att_reportrows of that lesson: same teacher, class, subject and report date,absCount > 0,createdAtfrom the lesson's first report up to (excluding) the next lesson of the same subject that day.createdAt:$gte/$lt,absCount:$gt). Roadmap entry added.Test plan
vite buildpasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
Generated by Claude Code