Skip to content

Teacher reported today: click missing count to show the girls' names - #206

Merged
buzz-code merged 2 commits into
mainfrom
claude/teacher-reported-today-missing-names
Oct 7, 2026
Merged

buzz-code merged 2 commits into
mainfrom
claude/teacher-reported-today-missing-names

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • In the "מורות שדיווחו" report, the missing-girls count pill is now a button. Clicking it opens a small popover listing the names; clicking outside closes it. Nothing is shown or fetched until clicked.
  • Names come from att_report rows of that lesson: same teacher, class, subject and report date, absCount > 0, createdAt from the lesson's first report up to (excluding) the next lesson of the same subject that day.
  • A count of 0 stays a plain "–" (not clickable).
  • Frontend only; uses existing CRUD filters (createdAt:$gte / $lt, absCount:$gt). Roadmap entry added.

Test plan

  • Local run with test data: class with the same subject twice (08:53 and 09:47). Clicking "2" shows 2 names, clicking "3" shows 3 names, matching the counts; every pill in the report matched its list length.
  • vite build passes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld


Generated by Claude Code

Names are fetched only on click, from att_report rows of that lesson
(same teacher, class, subject and date, absCount > 0), created from the
lesson's first report up to the next lesson of the same subject.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
Copilot AI balanced review requested due to automatic review settings October 7, 2026 17:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Pagination limits and null IDs can produce incomplete or incorrect name lists.

1 open finding
What changed in this PR

Adds clickable missing-girl counts with on-demand name popovers.

Changes:

  • Queries attendance records for selected lesson window.
  • Adds completed roadmap entry.
File Description
client/​src/​entities/​teacher-reported-today.jsx Adds missing-girl popover and queries.
client/​src/​roadmapFeatures.js Records feature completion.
Files not reviewed (1)
  • client/src/roadmapFeatures.js: Generated file

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@buzz-code
buzz-code merged commit aca6868 into main Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants