Repository navigation
Teacher reported today: class cards with a row per lesson and summary tiles - #205
Merged
Merged
Conversation
… tiles - One card per class, one row per lesson (time, subject, teacher, missing), sorted by report hour. Cards flow in CSS columns, so no gaps. - Single missing-girls count per lesson, colored by severity (none / 1-4 / 5+); no badge covering the hour. - Date shown only when the filter spans more than one day. - Summary tiles: lessons reported, classes, teachers, total missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Grouping, date visibility, and summary calculations produce incorrect results in supported cases.
Review effort: Balanced
Findings: 3
Open (3)
What changed in this PR
Redesigns teacher reporting view around class cards and lesson rows.
Changes:
- Adds summary tiles and severity-based missing counts.
- Groups lessons by class with responsive column layout.
- Adds completed roadmap entry.
| File | Description |
|---|---|
client/src/entities/teacher-reported-today.jsx |
Implements redesigned reporting view. |
client/src/roadmapFeatures.js |
Records completed redesign. |
Files not reviewed (1)
- client/src/roadmapFeatures.js: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The resource was gated by seminarAttendanceYemot only, so admins could not open it (and its admin-only user filter was unreachable). Gate it like the other report resources: permission or admin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
…rtial-load note - Lessons without a class are grouped per user (admin view). - Date column follows the filter range, not the returned rows. - Note when the server total exceeds the loaded rows (1000 cap). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Redesigns the "מורות שדיווחו" card view. This PR is frontend only; the server view from #204 already returns one row per lesson.
Before: one card per lesson with the class as a column header. Each card showed a red "חסרו N" label, a red badge with the same number covering the hour, and the date on every card even for a single-day filter. Fixed 220px class columns left large gaps.
After:
–, 1–4 orange, 5+ red (HIGH_MISSING_THRESHOLD).column-width: 340px), so tall and short classes pack without holes. On a phone the cards stack in one column.seminarAttendanceYemotonly, so admins could not reach it or its admin-only user filter. It's now gated like the other report resources: the permission or admin. The owning user is shown per class card.roadmapFeatures.js.Behavior change: teacher and lesson names are now plain text (
link={false}) instead of links to their records. The class name in the card header stays a link.Testing
jest: 214/214.vite buildOK.🤖 Generated with Claude Code
https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld