Repository navigation
Conversation
…ed today summary Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
Keep session creation gated by lessonSignature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Card logic, view aggregation, and migration align with intended behavior; no blocking issues remain.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes teacher report cards in attendance dashboard, with correct absence counts and lesson-specific times.
Changes:
- Converts absence counts to numbers, fixing totals and hiding zero badges.
- Splits cards by lesson.
- Uses per-lesson report times, with matching migration and rollback.
| File | Description |
|---|---|
| server/src/migrations/1791305020926-ReportHourPerLessonInTeacherReportedTodayView.ts | Updates view SQL and metadata; restores prior behavior on rollback. |
| server/src/db/view-entities/TeacherReportedToday.entity.ts | Computes earliest report time per lesson row. |
| client/src/entities/teacher-reported-today.jsx | Splits lesson cards and fixes numeric counts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Owner
Author
|
Superseded by #203 (DB ↔ TypeORM alignment only) and #204 (report changes, stacked on #203, now also splitting the same lesson taught twice in a day). Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes in the "מורות שדיווחו" (teacher_reported_today) card view:
missingGirlsCountcomes from MySQLCOUNT(BIGINT) as a string, so the card total concatenated (0 + "1" + "2"→חסרו 012). Cast toNumber. The same string caused a0badge to show on lessons with no absences; it's hidden now.reportHourwasMIN(...) OVER (PARTITION BY teacher, date, klass), so all of a teacher's lessons showed the same hour. NowMIN(createdAt)per lesson row. New migration1791305020926-ReportHourPerLessonInTeacherReportedTodayView; its SQL matches the TypeORM generated view exactly (no drift onmigration:generate).Not in this PR: same subject taught twice in one day still shows as one card (follow-up).
Testing
חסרו 012, shared hour. After: separate cards, own hours (08:52 / 10:30), correct totals, no0badge.migration:generate --dryrunshows noteacher_reported_todaydrift.yemot-handler.service.test.ts: 30/30 pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01Po2GocBhFneXD2k9z1f6Ld
Generated by Claude Code