Repository navigation
Seminar Yemot: ask caller for lesson number when no schedule matches - #200
Merged
Merged
Conversation
When today's LessonSchedule has no slot for the teacher+klass, the caller now types the lesson key (SEMINAR.LESSON_PROMPT, retry on SEMINAR.INVALID_LESSON). The resolved lesson feeds the existing duplicate-lesson question, so repeat punches are caught without schedules. Lesson keys are shared across klasses; klass still comes from the phone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NkWmy3KJrSBJj1xuCduZmg
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Star input causes lookup failure, while missing current-year lessons leave callers stuck retrying.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds manual lesson selection to seminar phone attendance when schedule lookup fails, extending existing duplicate-report checks.
Changes:
- Prompts for lesson key while keeping schedule matches preferred.
- Adds retry and duplicate-report scenarios.
- Seeds Hebrew lesson prompt and invalid-input texts.
| File | Description |
|---|---|
server/src/yemot-handler.service.ts |
Adds lesson-input fallback and duplicate checks. |
server/src/yemot-handler.service.test.ts |
Covers manual selection, retries, and duplicates. |
server/src/migrations/1791148265311-AddYemotTextsSeminarLessonPrompt.ts |
Adds two phone-flow texts with rollback. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…nput - No current-year lessons: skip the prompt and save without a lesson (previous behavior) instead of looping forever. - Non-digit input (e.g. '*') plays SEMINAR.INVALID_LESSON and retries instead of querying with NaN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NkWmy3KJrSBJj1xuCduZmg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Requested by Wolf: the responsible girl types the lesson number on the phone.
LessonSchedulehas no slot for teacher + klass, the caller is askedSEMINAR.LESSON_PROMPT("הקישי מספר השיעור הנלמד") and types the lessonkey. Invalid or non-numeric key →SEMINAR.INVALID_LESSON, retry.Notes
Lessonvia raw insert: its MySQL-only generated column (klass_reference_ids_json) is rejected by sqlite on repository save.Testing
cd server && yarn test: 119 suites, 1158 tests pass.*lesson retry, no lessons configured, typed lesson → duplicate question; existing no-schedule tests now assertlessonReferenceId.🤖 Generated with Claude Code
https://claude.ai/code/session_01NkWmy3KJrSBJj1xuCduZmg