Skip to content

chore: bump server/shared to 24971c57 (export 500 -> 400) - #199

Merged
buzz-code merged 1 commit into
mainfrom
chore/bump-server-shared-62
Oct 5, 2026
Merged

buzz-code merged 1 commit into
mainfrom
chore/bump-server-shared-62

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Bumps server/shared from 1aa6a67f to 24971c57.

Contains the fix merged in buzz-code/nra-server#62: GET /{resource}/export
(and the /pivot path whose extra.pivot carries /export) with an
unsupported or missing extra.format now returns HTTP 400 instead of
throwing a 500 — TypeError: Cannot read properties of undefined (reading 'format') at EntityController.exportFile. Both entry points are covered by
the single guard on exportFile.

No consumer-side action required: this delta only touches
base-entity/base-entity.controller.ts (+ its spec) and CONSUMER_CHANGES.md
(docs). None of the consumer-impacting commits listed there are in this delta.

Note: production is unchanged until the server image is rebuilt/redeployed.

Copilot AI balanced review requested due to automatic review settings October 5, 2026 04:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Scoped upstream fix includes regression coverage, with no unresolved findings or required consumer changes.

Review effort: Balanced
Findings: None

What changed in this PR

Bumps server/shared from 1aa6a67f to 24971c57 to fix export error responses.

Changes:

  • Returns HTTP 400 for missing or unsupported export formats, including pivot exports.
  • Includes upstream regression tests; no consumer changes required.
  • Takes effect after server rebuild/redeploy.
File Description

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@buzz-code
buzz-code merged commit 01945b3 into main Oct 5, 2026
5 checks passed
@buzz-code
buzz-code deleted the chore/bump-server-shared-62 branch October 5, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants