Repository navigation
chore: remove redundant per-app entities smoke test - #197
Merged
Merged
Conversation
client/src/entities.test.js was a byte-identical 5-line wrapper around client/shared's createResourceTests(App) - the shared shared/utils/testing/entities.test.js already does this exact thing automatically for any app, and self-skips via describe.skip(...) when it detects the app has its own copy (to avoid double-rendering every resource's List/Create/Edit page). Removing the per-app copy lets the shared file's real test run instead of skipping, with identical coverage - confirmed via a full client test run before/after (same pass count, one fewer skipped suite). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ogK8XQU9EwAhU3KcbCUMB
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The low-risk deletion has no blocking issues; the remaining documentation update is a minor nit.
Review effort: Lite
Findings: None
What changed in this PR
Removes a redundant, permanently skipped per-app entity smoke-test wrapper so the shared suite runs directly.
Changes:
- Deletes
client/src/entities.test.js. - Relies on the shared entity test suite for coverage.
- Minor documentation references should be updated to the shared test path.
| File | Summary |
|---|---|
client/src/entities.test.js |
Removes the duplicate test wrapper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client/src/entities.test.jswas a 5-line wrapper, byte-identical across all 5 apps, doing exactly whatclient/shared'sshared/utils/testing/entities.test.jsalready does automatically (createResourceTests(App)). The shared file detects a per-app copy and self-skips viadescribe.skip(...)to avoid double-rendering every resource's List/Create/Edit page — so the app-specific file added zero coverage, just a permanently-skipped duplicate suite.Removing it lets the shared file's real test run instead.
Verification
cd client && yarn test --watchAll=false: before → 34 passed / 35 total (1 skipped), 214/215 tests. After → 34/34 suites, 214/214 tests, 0 skipped. Identical coverage, one fewer (permanently-skipped) suite.Companion PRs opened on the other 4 apps that share this same pattern (nra-client's
entities.test.jsis the shared source, untouched here).🤖 Generated with Claude Code
https://claude.ai/code/session_013ogK8XQU9EwAhU3KcbCUMB
Generated by Claude Code