Skip to content

chore: remove redundant per-app entities smoke test - #197

Merged
buzz-code merged 1 commit into
mainfrom
chore/dedupe-entities-smoke-test
Sep 23, 2026
Merged

buzz-code merged 1 commit into
mainfrom
chore/dedupe-entities-smoke-test

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

client/src/entities.test.js was a 5-line wrapper, byte-identical across all 5 apps, doing exactly what client/shared's shared/utils/testing/entities.test.js already does automatically (createResourceTests(App)). The shared file detects a per-app copy and self-skips via describe.skip(...) to avoid double-rendering every resource's List/Create/Edit page — so the app-specific file added zero coverage, just a permanently-skipped duplicate suite.

Removing it lets the shared file's real test run instead.

Verification

  • cd client && yarn test --watchAll=false: before → 34 passed / 35 total (1 skipped), 214/215 tests. After → 34/34 suites, 214/214 tests, 0 skipped. Identical coverage, one fewer (permanently-skipped) suite.

Companion PRs opened on the other 4 apps that share this same pattern (nra-client's entities.test.js is the shared source, untouched here).


🤖 Generated with Claude Code

https://claude.ai/code/session_013ogK8XQU9EwAhU3KcbCUMB


Generated by Claude Code

client/src/entities.test.js was a byte-identical 5-line wrapper around
client/shared's createResourceTests(App) - the shared
shared/utils/testing/entities.test.js already does this exact thing
automatically for any app, and self-skips via describe.skip(...) when
it detects the app has its own copy (to avoid double-rendering every
resource's List/Create/Edit page).

Removing the per-app copy lets the shared file's real test run
instead of skipping, with identical coverage - confirmed via a full
client test run before/after (same pass count, one fewer skipped
suite).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013ogK8XQU9EwAhU3KcbCUMB
Copilot AI lite review requested due to automatic review settings September 23, 2026 04:26
@buzz-code
buzz-code merged commit 6d298bd into main Sep 23, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The low-risk deletion has no blocking issues; the remaining documentation update is a minor nit.

Review effort: Lite
Findings: None

What changed in this PR

Removes a redundant, permanently skipped per-app entity smoke-test wrapper so the shared suite runs directly.

Changes:

  • Deletes client/src/entities.test.js.
  • Relies on the shared entity test suite for coverage.
  • Minor documentation references should be updated to the shared test path.
File Summary
client/​src/​entities.test.js Removes the duplicate test wrapper.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants