Repository navigation
chore: bump server/shared ref to 395a1e9 (IsDigitsOnly/IsNumber coercion reuse) - #193
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Merged upstream change verified; tests pass; no consumer wiring required.
Pull request overview
Bumps server/shared to shared validator coercion ref.
Changes:
- Updates gitlink
642725f→395a1e9. - Adds centralized coercion for
IsDigitsOnlyandIsNumber. - Includes upstream test coverage.
File summaries
| File | Description |
|---|---|
server/shared |
Pins shared validation utilities commit |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
server/sharedsubmodule pointer from642725fto395a1e9— the merge of buzz-code/nra-server#58.Why
nra-server#58 makes
IsDigitsOnlyandIsNumberreuse the existingStringType/NumberTypehelpers fromutils/entity/class-transformer.tsinstead of inlining parallel transforms. That means a value coming from an Excel/CSV bulk upload (numeric string"12345"or a real number) is coerced centrally before the check runs, so it validates the same way the explicit@NumberTypefields already did.Composition is internal to the shared validators — no consumer-side wiring needed, so no
CONSUMER_CHANGES.mdrow.Diff
Submodule gitlink only:
Verification
npx jest shared/utils/validation shared/utils/entity/__tests__/class-transformer.spec.tson the bumped ref: 41/41 pass, 7 suites. No source changes in this repo — pointer bump only.