Skip to content

chore: bump server/shared ref to 395a1e9 (IsDigitsOnly/IsNumber coercion reuse) - #193

Merged
buzz-code merged 1 commit into
mainfrom
chore/bump-server-shared-58
Sep 17, 2026
Merged

buzz-code merged 1 commit into
mainfrom
chore/bump-server-shared-58

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

What

Bumps the server/shared submodule pointer from 642725f to 395a1e9 — the merge of buzz-code/nra-server#58.

Why

nra-server#58 makes IsDigitsOnly and IsNumber reuse the existing StringType/NumberType helpers from utils/entity/class-transformer.ts instead of inlining parallel transforms. That means a value coming from an Excel/CSV bulk upload (numeric string "12345" or a real number) is coerced centrally before the check runs, so it validates the same way the explicit @NumberType fields already did.

Composition is internal to the shared validators — no consumer-side wiring needed, so no CONSUMER_CHANGES.md row.

Diff

Submodule gitlink only:

-Subproject commit 642725f14b760e4d79968ec533275d42c9988364
+Subproject commit 395a1e9c62e2ecf59d184dfac0e247853776fdea

Verification

npx jest shared/utils/validation shared/utils/entity/__tests__/class-transformer.spec.ts on the bumped ref: 41/41 pass, 7 suites. No source changes in this repo — pointer bump only.

Copilot AI lite review requested due to automatic review settings September 17, 2026 05:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Merged upstream change verified; tests pass; no consumer wiring required.

Pull request overview

Bumps server/shared to shared validator coercion ref.

Changes:

  • Updates gitlink 642725f → 395a1e9.
  • Adds centralized coercion for IsDigitsOnly and IsNumber.
  • Includes upstream test coverage.
File summaries
File Description
server/shared Pins shared validation utilities commit
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@buzz-code
buzz-code merged commit 6d09162 into main Sep 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants