Repository navigation
Bump server/shared: fix race dropping first ask/response of every yemot call - #185
Merged
Merged
Conversation
…ot call The tz prompt (and any other first ask) was being silently dropped from the call's history due to a fire-and-forget race in call-tracking init. See buzz-code/nra-server#52. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPRtkZERPYou6is7GPAJhe
There was a problem hiding this comment.
🟡 Changes recommended
Shared call initialization path can introduce per-step DB round-trips unless initialize-call checks in-memory cache before querying DB.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Bumps server/shared (nra-server) to include fix for Yemot v2 call-tracking race where first ask_input / response step could be dropped because call row creation was fire-and-forget.
Changes:
- Update
server/sharedsubmodule tobuzz-code/nra-server#52. - Ensure call tracking initialization is awaited before first conversation-step logging.
Review notes (blocking):
- In new shared code,
initializeCall()is now invoked from request handling path; ifinitializeCall()always queries DB (even when call already cached), this adds avoidable DB load on every webhook step. Add fast-pathif (activeCalls.has(callId)) return;before DB lookup.
File summaries
| File | Description |
|---|---|
server/shared |
Submodule bump to pull in Yemot call tracking race fix. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server/sharedto yemot v2: fix race dropping the first ask/response of every call nra-server#52 (merged).YemotCallTrackingService.initializeCall(creates theYemotCallrow) ran fire-and-forget off thenew_callevent, letting the request handler's own path to the firstlogConversationStepwin the race almost every time — silently dropping the call's firstask_inputstep (e.g. the tz prompt) fromhistory. Confirmed happening on effectively every real call.🤖 Generated with Claude Code
https://claude.ai/code/session_01NPRtkZERPYou6is7GPAJhe
Generated by Claude Code