Skip to content

Bump server/shared: fix race dropping first ask/response of every yemot call - #185

Merged
buzz-code merged 1 commit into
mainfrom
claude/yemot-call-tz-filter-6603yx
Sep 6, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/yemot-call-tz-filter-6603yx

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Bumps server/shared to yemot v2: fix race dropping the first ask/response of every call nra-server#52 (merged).
  • Fixes a race where YemotCallTrackingService.initializeCall (creates the YemotCall row) ran fire-and-forget off the new_call event, letting the request handler's own path to the first logConversationStep win the race almost every time — silently dropping the call's first ask_input step (e.g. the tz prompt) from history. Confirmed happening on effectively every real call.
  • No API/schema change; consuming apps get the fix automatically after this bump.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NPRtkZERPYou6is7GPAJhe


Generated by Claude Code

…ot call

The tz prompt (and any other first ask) was being silently dropped from
the call's history due to a fire-and-forget race in call-tracking init.
See buzz-code/nra-server#52.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NPRtkZERPYou6is7GPAJhe
Copilot AI lite review requested due to automatic review settings September 6, 2026 16:40
@buzz-code
buzz-code merged commit c8dc6b5 into main Sep 6, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Shared call initialization path can introduce per-step DB round-trips unless initialize-call checks in-memory cache before querying DB.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Bumps server/shared (nra-server) to include fix for Yemot v2 call-tracking race where first ask_input / response step could be dropped because call row creation was fire-and-forget.

Changes:

  • Update server/shared submodule to buzz-code/nra-server#52.
  • Ensure call tracking initialization is awaited before first conversation-step logging.

Review notes (blocking):

  • In new shared code, initializeCall() is now invoked from request handling path; if initializeCall() always queries DB (even when call already cached), this adds avoidable DB load on every webhook step. Add fast-path if (activeCalls.has(callId)) return; before DB lookup.
File summaries
File Description
server/shared Submodule bump to pull in Yemot call tracking race fix.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants