Repository navigation
Bump client/shared: filter yemot calls by free-text search in history (tz) - #184
Merged
Merged
Conversation
… (tz) Lets admins find a yemot call by student tz (or any digits) without opening every call's dialog. Filters over the history column, which already logs every user-entered value per call - works on existing records too, no server-side change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPRtkZERPYou6is7GPAJhe
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPRtkZERPYou6is7GPAJhe
There was a problem hiding this comment.
🟢 Approval recommended
Change small, scoped to shared UI filter + translation, matches referenced nra-client#52 behavior.
Pull request overview
Bump client/shared submodule to include free-text search filter on yemot_call list, so admin can find call by student tz (or any entered digits/text) via history field, no server change.
Changes:
- Add always-on
history:$contfilter input toyemot_calllist filters. - Add i18n label for
history:$contfilter in shared entity translations.
File summaries
| File | Description |
|---|---|
| client/shared/components/common-entities/yemot-call.jsx | Add always-on history:$cont list filter input for yemot calls. |
| client/shared/entities/shared-entity.translations.js | Add Hebrew label for new history:$cont filter. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client/sharedto yemot_call: filter by free-text search in call history (finds student tz) nra-client#52 (merged).history:$contfilter on theyemot_calllist.historycolumn already logs every user-entered value per call, for old and new records, so no server-side change is needed.🤖 Generated with Claude Code
https://claude.ai/code/session_01NPRtkZERPYou6is7GPAJhe
Generated by Claude Code