Repository navigation
Bump client/shared: view-dialog button, empty-call indication, column reorder - #183
Merged
Merged
Conversation
… datetime, i18n) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
…edundant summary column, add lastSentMessage column Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
…ield Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
…ge unsortable fix) origin/main had independently bumped client/shared (a2f2768) and server/shared (332a24f) since this branch forked - a real 3-way divergence on both gitlinks, not just a stale-cache mergeable_state. Resolved by taking this branch's newer client/shared descendant (172c1b0, includes #49 and the #50 sortable fix) and main's newer server/shared (unrelated teacher-email-array work, untouched by this branch). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
…ndication, column reorder Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
There was a problem hiding this comment.
🟢 Approval recommended
Change limited to single submodule gitlink bump to commit that matches described nra-client PR, with no other repo diffs.
Pull request overview
Bump client/shared submodule pointer to b932f135e70473a95dcb8fa765ec2b75bb9af0c3 (nra-client PR #51), bringing UI tweaks for yemot_call table behavior into this repo via shared client package.
Changes:
- Update
client/sharedgitlink to new nra-client commit (#51) - No local repo code changes beyond submodule pointer bump
File summaries
| File | Description |
|---|---|
| client/shared | Update submodule commit pointer to nra-client change set (#51) |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Bumps
client/sharedto nra-client#51 (on top of the already-merged #49/#50 work):yemot_call's row is clickable to open the call dialog, but nothing signaled that — added a visible eye button next to the last-sent-message text.isOpen/hasError/errorMessagemoved to the end of the column list — usually constant, so the columns that actually vary lead the table.No changes needed in this repo beyond the pointer bump.
Testing
cd client && yarn test— 34 suites / 214 passed, 1 pre-existing skip.🤖 Generated with Claude Code
https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
Generated by Claude Code