Skip to content

Bump client/shared: modernize yemot_call table - #182

Merged
buzz-code merged 5 commits into
mainfrom
claude/modern-table-styling-li59j2
Sep 5, 2026
Merged

buzz-code merged 5 commits into
mainfrom
claude/modern-table-styling-li59j2

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

What changed

Bumps the client/shared submodule pointer to pick up nra-client#49, which modernizes the yemot_call ("שיחות") admin list:

  • Colored status pills for isOpen/hasError instead of plain check/X icons.
  • Phone number forced LTR + tabular-nums so digits stay aligned.
  • createdAt/updatedAt now render 24h with no seconds/AM-PM (previously fell back to the browser's locale instead of the app's Hebrew/24h convention).
  • New lastSentMessage column next to errorMessage, showing the last bot prompt actually sent regardless of the caller's answer.
  • Dropped the old history-summary column (last-action chip + hint icon) — redundant with the row-click-to-dialog flow.
  • Theme polish: rounded filter/search inputs to match buttons/cards/chips, hover tint on the sidebar's active-link style.

No changes needed in this repo beyond the pointer bump — the shared change is additive.

Merge order: land nra-client#49 first, then this PR.

Testing

cd client && yarn test — 34 suites / 213 passed, 1 pre-existing skip.


🤖 Generated with Claude Code

https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon


Generated by Claude Code

… datetime, i18n)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
…edundant summary column, add lastSentMessage column

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
Copilot AI lite review requested due to automatic review settings September 5, 2026 19:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

New shared yemot_call list adds derived LastSentMessageField with source="lastSentMessage" which becomes sortable by default and will 400 on server (Invalid field: lastSentMessage) since YemotCall entity has no such column; fix needs new submodule commit disabling sort (e.g., sortable={false}).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

PR bumps client/shared submodule pointer to pick up nra-client#49 UI updates for Yemot “שיחות” (yemot_call) admin list.

Changes:

  • Update client/shared submodule from 75eede29831d9148e221487d91a7ba707bbd0a0c to f7f48bd0380a133f2a22c246fa7b9b7b971be973.
File summaries
File Description
client/shared Move submodule pointer to newer nra-client commit with yemot_call list modernization.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…ge unsortable fix)

origin/main had independently bumped client/shared (a2f2768) and
server/shared (332a24f) since this branch forked - a real 3-way
divergence on both gitlinks, not just a stale-cache mergeable_state.
Resolved by taking this branch's newer client/shared descendant
(172c1b0, includes #49 and the #50 sortable fix) and main's newer
server/shared (unrelated teacher-email-array work, untouched by this
branch).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
@buzz-code
buzz-code merged commit 7185366 into main Sep 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants