Repository navigation
Bump client/shared: modernize yemot_call table - #182
Merged
Merged
Conversation
… datetime, i18n) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
…edundant summary column, add lastSentMessage column Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
…ield Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
There was a problem hiding this comment.
🟡 Changes recommended
New shared yemot_call list adds derived LastSentMessageField with source="lastSentMessage" which becomes sortable by default and will 400 on server (Invalid field: lastSentMessage) since YemotCall entity has no such column; fix needs new submodule commit disabling sort (e.g., sortable={false}).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
PR bumps client/shared submodule pointer to pick up nra-client#49 UI updates for Yemot “שיחות” (yemot_call) admin list.
Changes:
- Update
client/sharedsubmodule from75eede29831d9148e221487d91a7ba707bbd0a0ctof7f48bd0380a133f2a22c246fa7b9b7b971be973.
File summaries
| File | Description |
|---|---|
client/shared |
Move submodule pointer to newer nra-client commit with yemot_call list modernization. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ge unsortable fix) origin/main had independently bumped client/shared (a2f2768) and server/shared (332a24f) since this branch forked - a real 3-way divergence on both gitlinks, not just a stale-cache mergeable_state. Resolved by taking this branch's newer client/shared descendant (172c1b0, includes #49 and the #50 sortable fix) and main's newer server/shared (unrelated teacher-email-array work, untouched by this branch). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Bumps the
client/sharedsubmodule pointer to pick up nra-client#49, which modernizes theyemot_call("שיחות") admin list:isOpen/hasErrorinstead of plain check/X icons.createdAt/updatedAtnow render 24h with no seconds/AM-PM (previously fell back to the browser's locale instead of the app's Hebrew/24h convention).lastSentMessagecolumn next toerrorMessage, showing the last bot prompt actually sent regardless of the caller's answer.No changes needed in this repo beyond the pointer bump — the shared change is additive.
Merge order: land nra-client#49 first, then this PR.
Testing
cd client && yarn test— 34 suites / 213 passed, 1 pre-existing skip.🤖 Generated with Claude Code
https://claude.ai/code/session_01QtUC1hhZBNwRYmjMmWPvon
Generated by Claude Code