Repository navigation
teacher-reported-today: sort cards by reportHour ascending - #181
Merged
Merged
Conversation
Cards were sorted by reportDate DESC, which is a no-op within a single day (the default filter view) since every row shares the same date - actual card order fell back to whatever order the view query happened to return. Sort by reportHour ascending instead, so the earliest report of the day shows first. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeX6BFe7P4pHLPm3VwFjPn
There was a problem hiding this comment.
🟢 Approval recommended
Change aligns with view field semantics (reportHour exists, used in UI) and fixes ordering bug with minimal, low-risk diff.
Pull request overview
Fix card ordering on teacher_reported_today list so earliest report shows first for default “today” filter.
Changes:
- Switch React-Admin list sort from
reportDate DESCtoreportHour ASC - Keep sort consistent in both custom
Listcomponent andentityconfig
File summaries
| File | Description |
|---|---|
| client/src/entities/teacher-reported-today.jsx | Change list default sort to reportHour ascending so card order matches report time |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cards on the "teachers who reported attendance" screen weren't ordered as expected — the earlier report should show first, not last.
Root cause
Sort was
{ field: 'reportDate', order: 'DESC' }.reportDateis the same value for every row in the default "today" filter, so this sort was a no-op — actual card order fell back to whatever incidental order the underlying view query returned.Change
Sort by
reportHourascending instead (the real per-report timestamp), so the earliest report of the day shows first.Testing
cd client && yarn build— cleancd client && yarn test— 31/32 suites passing (1 pre-existing skip, unrelated)🤖 Generated with Claude Code
https://claude.ai/code/session_01KeX6BFe7P4pHLPm3VwFjPn
Generated by Claude Code