Repository navigation
Bump client/shared for yemot_call row-click + deep link - #179
Merged
Merged
Conversation
client/shared -> a2f2768 (nra-client#48): row click opens the call details dialog, deep-linkable via a callId URL param with a copy-link button, drops the previously-wrong "N צעדים" step count, and moves yemot_call into the existing data menu group. No consumer-side change required. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012tsnbwBMV5zfSEYJ8UiQBr
There was a problem hiding this comment.
🟡 Changes recommended
Submodule bump includes yemot_call deep-link code path that ignores fetch failures and bypasses v2-only gating, risking URL/dialog state mismatch.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Bump client/shared submodule pointer from 75eede2 to a2f2768 to pull in nra-client changes for yemot_call UX: row-click opens details dialog, dialog deep-link via callId URL param, remove misleading “N צעדים” count, move resource into data menu group.
Changes:
- Update
client/sharedgitlink toa2f2768537863afafd258edf318c5704ffce7072.
Review notes:
- New deep-link flow in
client/shared/components/common-entities/yemot-call.jsxswallowsdataProvider.getOne()errors and can open dialog for non‑v2callId(rowClick blocks non‑v2). Consider fix innra-clientthen bump again.
File summaries
| File | Description |
|---|---|
client/shared |
Submodule pointer bump to a2f2768 (yemot_call row-click + callId deep link + menu grouping + step-count removal). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
client/shared→a2f2768(nra-client#48):callIdURL param, with a "העתק קישור" copy-link button inside it.yemot_callmoved into the existing "data" menu group instead of sitting ungrouped.Pointer-only bump, no consumer-side change required.
🤖 Generated with Claude Code
Generated by Claude Code