Skip to content

Bump client/shared for yemot_call row-click + deep link - #179

Merged
buzz-code merged 1 commit into
mainfrom
claude/bump-yemot-call-rowclick-deeplink
Sep 5, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/bump-yemot-call-rowclick-deeplink

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

What

Bumps client/shared → a2f2768 (nra-client#48):

  • Clicking anywhere on a call row opens its details dialog (previously only a small icon worked).
  • The dialog is deep-linkable via a callId URL param, with a "העתק קישור" copy-link button inside it.
  • Dropped the "N צעדים" step count (list row and dialog header both showed it) — it counted raw log entries including duplicate-bug rows the dialog already hides, so it never matched what was actually shown.
  • yemot_call moved into the existing "data" menu group instead of sitting ungrouped.

Pointer-only bump, no consumer-side change required.

🤖 Generated with Claude Code


Generated by Claude Code

client/shared -> a2f2768 (nra-client#48): row click opens the call
details dialog, deep-linkable via a callId URL param with a copy-link
button, drops the previously-wrong "N צעדים" step count, and moves
yemot_call into the existing data menu group. No consumer-side change
required.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012tsnbwBMV5zfSEYJ8UiQBr
Copilot AI lite review requested due to automatic review settings September 5, 2026 18:54
@buzz-code
buzz-code merged commit 2915d6f into main Sep 5, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Submodule bump includes yemot_call deep-link code path that ignores fetch failures and bypasses v2-only gating, risking URL/dialog state mismatch.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Bump client/shared submodule pointer from 75eede2 to a2f2768 to pull in nra-client changes for yemot_call UX: row-click opens details dialog, dialog deep-link via callId URL param, remove misleading “N צעדים” count, move resource into data menu group.

Changes:

  • Update client/shared gitlink to a2f2768537863afafd258edf318c5704ffce7072.

Review notes:

  • New deep-link flow in client/shared/components/common-entities/yemot-call.jsx swallows dataProvider.getOne() errors and can open dialog for non‑v2 callId (rowClick blocks non‑v2). Consider fix in nra-client then bump again.
File summaries
File Description
client/shared Submodule pointer bump to a2f2768 (yemot_call row-click + callId deep link + menu grouping + step-count removal).
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants