Skip to content

Bump client/shared for staff yemot call history access - #176

Merged
buzz-code merged 1 commit into
mainfrom
claude/bump-view-yemot-calls-permission
Sep 4, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/bump-view-yemot-calls-permission

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

What

Bumps client/shared → 75eede2 (nra-client#46):

  • New viewYemotCalls permission — an admin can now grant a non-admin staff login access to the call log (picked up automatically by the User edit screen's permission checkbox list, no code needed there).
  • createdAt un-hidden for non-admin, with its own date-range filter (previously only admins had any date filter).
  • yemot_call moved out of the "Admin" menu group — it now stands alone in the sidebar, since it's no longer admin-only.

Pointer-only bump, no consumer-side change required (purely additive, backward-compatible).

🤖 Generated with Claude Code


Generated by Claude Code

client/shared -> 75eede2 (nra-client#46): new viewYemotCalls
permission lets non-admin staff view the call log; createdAt un-hidden
+ its own date filter for them; resource moved out of the admin menu
group. No consumer-side change required (purely additive).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012tsnbwBMV5zfSEYJ8UiQBr
Copilot AI lite review requested due to automatic review settings September 4, 2026 09:15
@buzz-code
buzz-code merged commit 5a9f3e3 into main Sep 4, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Backend still appears to gate yemot_call via default CRUD auth (non-admin userId-scoped), so new viewYemotCalls permission may not grant intended call-log access end-to-end without matching server-side auth/config update.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Bump client/shared submodule to 75eede2 (nra-client#46) to expose Yemot call-log UI to non-admin staff via new viewYemotCalls permission, plus non-admin createdAt filter and sidebar regroup.

Changes:

  • Add viewYemotCalls permission key in shared client permissions + resource gating.
  • Show createdAt column + date-range filters for non-admin in yemot_call list.
  • Move yemot_call out of Admin menu group.
File summaries
File Description
client/shared Submodule bump pulling shared client permission + yemot_call UI updates
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants