Repository navigation
Bump client/shared for staff yemot call history access - #176
Merged
Merged
Conversation
client/shared -> 75eede2 (nra-client#46): new viewYemotCalls permission lets non-admin staff view the call log; createdAt un-hidden + its own date filter for them; resource moved out of the admin menu group. No consumer-side change required (purely additive). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012tsnbwBMV5zfSEYJ8UiQBr
There was a problem hiding this comment.
🟡 Changes recommended
Backend still appears to gate yemot_call via default CRUD auth (non-admin userId-scoped), so new viewYemotCalls permission may not grant intended call-log access end-to-end without matching server-side auth/config update.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Bump client/shared submodule to 75eede2 (nra-client#46) to expose Yemot call-log UI to non-admin staff via new viewYemotCalls permission, plus non-admin createdAt filter and sidebar regroup.
Changes:
- Add
viewYemotCallspermission key in shared client permissions + resource gating. - Show
createdAtcolumn + date-range filters for non-admin inyemot_calllist. - Move
yemot_callout of Admin menu group.
File summaries
| File | Description |
|---|---|
client/shared |
Submodule bump pulling shared client permission + yemot_call UI updates |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
client/shared→75eede2(nra-client#46):viewYemotCallspermission — an admin can now grant a non-admin staff login access to the call log (picked up automatically by the User edit screen's permission checkbox list, no code needed there).createdAtun-hidden for non-admin, with its own date-range filter (previously only admins had any date filter).yemot_callmoved out of the "Admin" menu group — it now stands alone in the sidebar, since it's no longer admin-only.Pointer-only bump, no consumer-side change required (purely additive, backward-compatible).
🤖 Generated with Claude Code
Generated by Claude Code