Repository navigation
Shrink teacher-reported-today cards, show missing-girls count on every card - #173
Merged
Merged
Conversation
…very card - reduce card/column padding, font sizes and gaps so more cards fit per screen - show a total missing-girls count in each card's header (sum of its lesson counts, or the card's own count when it has no lesson breakdown), not just on lesson chips Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UFsJW6shPwXgjbXDm6kRG
There was a problem hiding this comment.
🟡 Changes recommended
Layout change removes horizontal overflow handling, can break usability on narrow viewports due to fixed 220px columns without scroll.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
UI tweak for teacher-reported-today React-Admin entity view: fit more teacher cards per screen, add per-card total missing-girls count in header.
Changes:
- Add
getTotalMissingGirls()helper, render total missing-girls in each card header - Tighten spacing: smaller padding/gaps, smaller typography variants, smaller min column width
- Change columns container from horizontal scroll to wrapping layout
File summaries
| File | Description |
|---|---|
| client/src/entities/teacher-reported-today.jsx | Add total-missing-girls header, shrink card/column styling, wrap columns |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Per Copilot review: fixed 220px columns with no shrink can overflow on viewports narrower than one column. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UFsJW6shPwXgjbXDm6kRG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
teacher-reported-todayso more cards fit per screen (smaller min column width, wrapping columns instead of only horizontal scroll).Test plan
yarn test).🤖 Generated with Claude Code
Generated by Claude Code