Skip to content

Shrink teacher-reported-today cards, show missing-girls count on every card - #173

Merged
buzz-code merged 2 commits into
mainfrom
claude/missing-girls-per-lesson-55lfzn
Sep 4, 2026
Merged

buzz-code merged 2 commits into
mainfrom
claude/missing-girls-per-lesson-55lfzn

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Shrink card/column padding, font sizes, and gaps in teacher-reported-today so more cards fit per screen (smaller min column width, wrapping columns instead of only horizontal scroll).
  • Show a total missing-girls count in every card's header — sum of its lesson counts, or the card's own count when it has no lesson breakdown (the "ללא שיוך שיעור" case) — in addition to the existing per-lesson badge.

Test plan

  • Manual review of the JSX changes (no local DB/build available in this session to run yarn test).

🤖 Generated with Claude Code


Generated by Claude Code

…very card

- reduce card/column padding, font sizes and gaps so more cards fit per screen
- show a total missing-girls count in each card's header (sum of its lesson
  counts, or the card's own count when it has no lesson breakdown), not just
  on lesson chips

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UFsJW6shPwXgjbXDm6kRG
Copilot AI lite review requested due to automatic review settings September 4, 2026 07:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Layout change removes horizontal overflow handling, can break usability on narrow viewports due to fixed 220px columns without scroll.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

UI tweak for teacher-reported-today React-Admin entity view: fit more teacher cards per screen, add per-card total missing-girls count in header.

Changes:

  • Add getTotalMissingGirls() helper, render total missing-girls in each card header
  • Tighten spacing: smaller padding/gaps, smaller typography variants, smaller min column width
  • Change columns container from horizontal scroll to wrapping layout
File summaries
File Description
client/src/entities/teacher-reported-today.jsx Add total-missing-girls header, shrink card/column styling, wrap columns
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Per Copilot review: fixed 220px columns with no shrink can overflow on
viewports narrower than one column.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UFsJW6shPwXgjbXDm6kRG
@buzz-code
buzz-code merged commit 3b440b7 into main Sep 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants