Skip to content

Show missing-girls count per lesson, show all rows on teacher-reported-today - #168

Merged
buzz-code merged 3 commits into
mainfrom
claude/missing-girls-per-lesson-55lfzn
Sep 2, 2026
Merged

buzz-code merged 3 commits into
mainfrom
claude/missing-girls-per-lesson-55lfzn

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Add missingGirlsCount to the teacher_reported_today view — counts distinct students with absCount > 0 per teacher+lesson+date+klass.
  • Show that count as a badge on each lesson chip in the teacher-reported-today card view.
  • Give teacher-reported-today its own list with a high perPage and no pagination footer, since it's a card view rather than a table — previously capped at 10 rows.
  • Migration file uses a real epoch-ms timestamp.

Test plan

  • Manual review of the view SQL and client rendering (no local DB/build available in this session to run migrations or yarn test).

🤖 Generated with Claude Code


Generated by Claude Code

- add missingGirlsCount aggregate to teacher_reported_today view
- render count as MUI Badge on each lesson chip in the client

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UFsJW6shPwXgjbXDm6kRG
…oday

- rename the missing-girls-count view migration to a real epoch timestamp
- give teacher-reported-today its own list with a high perPage cap and
  no pagination footer, since it's a card view rather than a table

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UFsJW6shPwXgjbXDm6kRG
Copilot AI lite review requested due to automatic review settings September 2, 2026 15:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Custom List component does not forward react-admin List props into CommonList, risking behavior regressions when List configured with additional props.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Add missingGirlsCount to teacher_reported_today view, surface count in React-Admin card UI, and lift default 10-row fetch limit for card view.

Changes:

  • Extend MySQL view teacher_reported_today with missingGirlsCount (distinct students with absCount > 0 per teacher+lesson+date+klass).
  • Map new field in TeacherReportedToday view-entity.
  • Show missingGirlsCount badge on lesson chips; use custom List with high perPage and no pagination footer.
File summaries
File Description
server/src/migrations/1788336876049-AddMissingGirlsCountToTeacherReportedTodayView.ts Recreate teacher_reported_today view to add missingGirlsCount and update typeorm_metadata.
server/src/db/view-entities/TeacherReportedToday.entity.ts Add select + column mapping for missingGirlsCount in TypeORM view entity.
client/src/entities/teacher-reported-today.jsx Render missingGirlsCount as badge on lesson chip; replace default list with card-oriented CommonList config.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Matches the shared CommonEntity List's own contract, per Copilot review.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UFsJW6shPwXgjbXDm6kRG
@buzz-code
buzz-code merged commit db3b1e3 into main Sep 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants