Repository navigation
Show missing-girls count per lesson, show all rows on teacher-reported-today - #168
Merged
Merged
Conversation
- add missingGirlsCount aggregate to teacher_reported_today view - render count as MUI Badge on each lesson chip in the client Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UFsJW6shPwXgjbXDm6kRG
…oday - rename the missing-girls-count view migration to a real epoch timestamp - give teacher-reported-today its own list with a high perPage cap and no pagination footer, since it's a card view rather than a table Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UFsJW6shPwXgjbXDm6kRG
There was a problem hiding this comment.
🟡 Changes recommended
Custom List component does not forward react-admin List props into CommonList, risking behavior regressions when List configured with additional props.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Add missingGirlsCount to teacher_reported_today view, surface count in React-Admin card UI, and lift default 10-row fetch limit for card view.
Changes:
- Extend MySQL view
teacher_reported_todaywithmissingGirlsCount(distinct students withabsCount > 0per teacher+lesson+date+klass). - Map new field in
TeacherReportedTodayview-entity. - Show
missingGirlsCountbadge on lesson chips; use custom List with highperPageand no pagination footer.
File summaries
| File | Description |
|---|---|
| server/src/migrations/1788336876049-AddMissingGirlsCountToTeacherReportedTodayView.ts | Recreate teacher_reported_today view to add missingGirlsCount and update typeorm_metadata. |
| server/src/db/view-entities/TeacherReportedToday.entity.ts | Add select + column mapping for missingGirlsCount in TypeORM view entity. |
| client/src/entities/teacher-reported-today.jsx | Render missingGirlsCount as badge on lesson chip; replace default list with card-oriented CommonList config. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Matches the shared CommonEntity List's own contract, per Copilot review. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011UFsJW6shPwXgjbXDm6kRG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
missingGirlsCountto theteacher_reported_todayview — counts distinct students withabsCount > 0per teacher+lesson+date+klass.teacher-reported-todayits own list with a highperPageand no pagination footer, since it's a card view rather than a table — previously capped at 10 rows.Test plan
yarn test).🤖 Generated with Claude Code
Generated by Claude Code