Repository navigation
Make lesson optional on attendance report edit form - #165
Merged
Merged
Conversation
lessonReferenceId was required() on the client edit form even though the server already allows it empty — attendance rows without a lesson name couldn't be edited. Drop the client-side requirement.
There was a problem hiding this comment.
🟢 Approval recommended
Small client-only validation change aligns form behavior with server model and fixes blocked edits for rows with no lesson.
Pull request overview
Make lessonReferenceId optional on attendance report edit/create form, aligning client validation with server entity allowing rows with no lesson.
Changes:
- Remove
required()validation fromlessonReferenceIdCommonReferenceInputin att report form
File summaries
| File | Description |
|---|---|
| client/src/entities/att-report.jsx | Drop client-side required validation for lessonReferenceId input |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editing an attendance report row demanded a lesson name even when none exists for that row.
Root cause
lessonReferenceIdhadvalidate={required()}on the client edit form (client/src/entities/att-report.jsx), but the server entity already allows it empty (only one oflessonId/lessonReferenceIdis conditionally required, not both).Change
Dropped the client-side
required()validation onlessonReferenceId.Testing
cd client && yarn build— clean🤖 Generated with Claude Code
Generated by Claude Code