Repository navigation
Allow repeated seminar attendance reports for same klass same day - #163
Merged
Merged
Conversation
Removed the once-per-day block on klass attendance calls (Yemot seminar flow) so teachers can report again for the same klass repeatedly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FTDr8b97bC1f5CTV4geQRP
There was a problem hiding this comment.
🟢 Approval recommended
Change matches stated requirement, removes now-dead helper, updates test to cover new repeat-report behavior.
Pull request overview
Remove once-per-day lock in Yemot seminar attendance flow so teacher can submit multiple attendance reports for same klass same day.
Changes:
- Remove
hasReportedTodayForKlassguard + delete helper fromprocessSeminarAttendanceCall - Update Jest test to assert repeat report succeeds (no
SEMINAR.ALREADY_REPORTEDhangup)
File summaries
| File | Description |
|---|---|
| server/src/yemot-handler.service.ts | Remove “already reported today” block for seminar attendance calls |
| server/src/yemot-handler.service.test.ts | Replace “already reported” hangup test with repeat-report success test |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processSeminarAttendanceCall) blocked a second report for the same klass on the same day (hasReportedTodayForKlass+SEMINAR.ALREADY_REPORTED). Removed this once-per-day block so teachers can report again for the same klass repeatedly, as requested.Changes
server/src/yemot-handler.service.ts: removedhasReportedTodayForKlasscheck and the now-unused private method fromprocessSeminarAttendanceCall.server/src/yemot-handler.service.test.ts: replaced the "already reported" hangup test with a test confirming a repeat report for the same klass succeeds.Testing
yarn test(server) — 1013 passed, 114 suites.Generated by Claude Code