Skip to content

Allow repeated seminar attendance reports for same klass same day - #163

Merged
buzz-code merged 1 commit into
mainfrom
claude/repeated-class-reporting-r22ybt
Sep 1, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/repeated-class-reporting-r22ybt

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Yemot seminar attendance calls (processSeminarAttendanceCall) blocked a second report for the same klass on the same day (hasReportedTodayForKlass + SEMINAR.ALREADY_REPORTED). Removed this once-per-day block so teachers can report again for the same klass repeatedly, as requested.
  • Note: the block was a full-day lock, not a time-interval cooldown between classes — there was no configurable gap to tune.

Changes

  • server/src/yemot-handler.service.ts: removed hasReportedTodayForKlass check and the now-unused private method from processSeminarAttendanceCall.
  • server/src/yemot-handler.service.test.ts: replaced the "already reported" hangup test with a test confirming a repeat report for the same klass succeeds.

Testing

  • yarn test (server) — 1013 passed, 114 suites.

Generated by Claude Code

Removed the once-per-day block on klass attendance calls (Yemot
seminar flow) so teachers can report again for the same klass
repeatedly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FTDr8b97bC1f5CTV4geQRP
Copilot AI lite review requested due to automatic review settings September 1, 2026 06:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Change matches stated requirement, removes now-dead helper, updates test to cover new repeat-report behavior.

Pull request overview

Remove once-per-day lock in Yemot seminar attendance flow so teacher can submit multiple attendance reports for same klass same day.

Changes:

  • Remove hasReportedTodayForKlass guard + delete helper from processSeminarAttendanceCall
  • Update Jest test to assert repeat report succeeds (no SEMINAR.ALREADY_REPORTED hangup)
File summaries
File Description
server/src/yemot-handler.service.ts Remove “already reported today” block for seminar attendance calls
server/src/yemot-handler.service.test.ts Replace “already reported” hangup test with repeat-report success test
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@buzz-code
buzz-code merged commit f2374cc into main Sep 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants