Skip to content

Show student number on the student-klass assignment screen - #159

Merged
buzz-code merged 1 commit into
mainfrom
claude/phone-classes-requirements-7u7bi7
Aug 25, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/phone-classes-requirements-7u7bi7

Conversation

@buzz-code

@buzz-code buzz-code commented Aug 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

Requested so the (existing, student-level) student number is visible together with the class assignment, without duplicating it as a separate editable field.

  • No schema change — displays Student.studentNumber via the student join already available on this screen, same pattern as the existing tz column
  • Added to the list view and the export headers

History note

Earlier commits on this branch added studentNumber as a new writable column on StudentKlass itself (with a migration, uniqueness constraint, etc.) — that was the wrong read on the request. The branch was reset and rebuilt as a display-only field once clarified; final diff is display-only, no migration.

Copilot AI lite review requested due to automatic review settings August 25, 2026 09:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Change set consistent across migration, entity metadata, admin UI, and export, with nullable+unique semantics implemented end-to-end.

Pull request overview

Add per-class student number on student-klass assignment, so admin list/form/export show number next to assignment (not only on student record).

Changes:

  • Add student_klasses.student_number (nullable) + unique index per (user_id, klassReferenceId, year, student_number)
  • Add StudentKlass.studentNumber with empty-string → null normalization + uniqueness validation metadata
  • Expose studentNumber in React-Admin list, form, importer, translations, server export headers
File summaries
File Description
server/src/migrations/1787400000000-AddStudentNumberToStudentKlasses.ts Add DB column + unique index for per-class student number
server/src/entity-modules/student-klass.config.ts Add studentNumber to export headers
server/src/db/entities/StudentKlass.entity.ts Add studentNumber field, unique index metadata, normalize '' → null
client/src/entities/student-klass.jsx Show/edit/import studentNumber in admin UI
client/src/domainTranslations.js Add Hebrew label for studentNumber
Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Requested so the (existing, student-level) student number is visible
together with the class assignment, without a data-entry duplicate.

- No schema change: displays Student.studentNumber via the existing
  student join, same pattern already used for the tz column
- Same field added to the export headers

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HXGT749AjJ6BDgDqvQXQX2
@buzz-code
buzz-code force-pushed the claude/phone-classes-requirements-7u7bi7 branch from 28962d2 to 8305631 Compare August 25, 2026 09:26
@buzz-code buzz-code changed the title Add student number to the student-klass assignment table Show student number on the student-klass assignment screen Aug 25, 2026
@buzz-code
buzz-code requested a lite review from Copilot August 25, 2026 09:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Small display-only change with server-side export header + matching test update, no schema or behavior risk found.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@buzz-code
buzz-code merged commit dd21a14 into main Aug 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants