Repository navigation
Show student number on the student-klass assignment screen - #159
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Change set consistent across migration, entity metadata, admin UI, and export, with nullable+unique semantics implemented end-to-end.
Pull request overview
Add per-class student number on student-klass assignment, so admin list/form/export show number next to assignment (not only on student record).
Changes:
- Add
student_klasses.student_number(nullable) + unique index per (user_id,klassReferenceId,year,student_number) - Add
StudentKlass.studentNumberwith empty-string → null normalization + uniqueness validation metadata - Expose
studentNumberin React-Admin list, form, importer, translations, server export headers
File summaries
| File | Description |
|---|---|
| server/src/migrations/1787400000000-AddStudentNumberToStudentKlasses.ts | Add DB column + unique index for per-class student number |
| server/src/entity-modules/student-klass.config.ts | Add studentNumber to export headers |
| server/src/db/entities/StudentKlass.entity.ts | Add studentNumber field, unique index metadata, normalize '' → null |
| client/src/entities/student-klass.jsx | Show/edit/import studentNumber in admin UI |
| client/src/domainTranslations.js | Add Hebrew label for studentNumber |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Requested so the (existing, student-level) student number is visible together with the class assignment, without a data-entry duplicate. - No schema change: displays Student.studentNumber via the existing student join, same pattern already used for the tz column - Same field added to the export headers Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXGT749AjJ6BDgDqvQXQX2
buzz-code
force-pushed
the
claude/phone-classes-requirements-7u7bi7
branch
from
August 25, 2026 09:26
28962d2 to
8305631
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requested so the (existing, student-level) student number is visible together with the class assignment, without duplicating it as a separate editable field.
Student.studentNumbervia the student join already available on this screen, same pattern as the existingtzcolumnHistory note
Earlier commits on this branch added
studentNumberas a new writable column onStudentKlassitself (with a migration, uniqueness constraint, etc.) — that was the wrong read on the request. The branch was reset and rebuilt as a display-only field once clarified; final diff is display-only, no migration.