Repository navigation
Conversation
Picks up nra-server#42: Schedule.nextRunAt is now reset (nulled) when cronExpression/timeZone changes via PATCH, so the heartbeat recomputes it fresh on the next tick instead of leaving a stale value from the previous cron in place. Purely additive - no consumer action needed (no CONSUMER_CHANGES.md row for this commit). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011dEYULADLgGNfZ4nv6gz8s
There was a problem hiding this comment.
🔵 Needs a closer look
No reviewed files or final review comments were supplied, so approval cannot be confirmed safely.
Pull request overview
Bumps server/shared to include the schedule nextRunAt reset-on-edit fix.
Changes:
- Resets
nextRunAtwhen cron or timezone changes. - Updates the nra-server submodule and adds regression coverage.
File summaries
| File | Description |
|---|
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Owner
Author
|
Closing without merging — Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
server/shared(nra-server) from1bdb729to2f526d4, picking up nra-server#42:Schedule.nextRunAtis now reset (nulled) whencronExpression/timeZonechanges viaPATCH /schedule/:id, soScheduleHeartbeatServicerecomputes it fresh on the next tick instead of leaving a stale value from the previous cron in place.Pointer-only bump — no
CONSUMER_CHANGES.mdrow for this commit, purely additive.Testing
Fresh clone +
git submodule update --init --depth 1:tsc --noEmitcleanyarn test— 113 suites / 1003 tests passed🤖 Generated with Claude Code
Generated by Claude Code