Skip to content

chore: bump server/shared (nextRunAt reset-on-edit fix) - #155

Closed
buzz-code wants to merge 1 commit into
mainfrom
claude/bump-server-shared-schedule-fix
Closed

buzz-code wants to merge 1 commit into
mainfrom
claude/bump-server-shared-schedule-fix

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

Bumps server/shared (nra-server) from 1bdb729 to 2f526d4, picking up nra-server#42: Schedule.nextRunAt is now reset (nulled) when cronExpression/timeZone changes via PATCH /schedule/:id, so ScheduleHeartbeatService recomputes it fresh on the next tick instead of leaving a stale value from the previous cron in place.

Pointer-only bump — no CONSUMER_CHANGES.md row for this commit, purely additive.

Testing

Fresh clone + git submodule update --init --depth 1:

  • tsc --noEmit clean
  • yarn test — 113 suites / 1003 tests passed

🤖 Generated with Claude Code


Generated by Claude Code

Picks up nra-server#42: Schedule.nextRunAt is now reset (nulled) when
cronExpression/timeZone changes via PATCH, so the heartbeat recomputes
it fresh on the next tick instead of leaving a stale value from the
previous cron in place.

Purely additive - no consumer action needed (no CONSUMER_CHANGES.md
row for this commit).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011dEYULADLgGNfZ4nv6gz8s
Copilot AI lite review requested due to automatic review settings August 23, 2026 19:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

No reviewed files or final review comments were supplied, so approval cannot be confirmed safely.

Pull request overview

Bumps server/shared to include the schedule nextRunAt reset-on-edit fix.

Changes:

  • Resets nextRunAt when cron or timezone changes.
  • Updates the nra-server submodule and adds regression coverage.
File summaries
File Description
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copy link
Copy Markdown
Owner Author

Closing without merging — main already picked up server/shared bumped to e111387 (via a separate commit), which is a descendant of 2f526d4 (the commit this PR targeted). This PR's change is now redundant.


Generated by Claude Code

@buzz-code buzz-code closed this Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants