Skip to content

Bump server/shared: TypeORM query logs now route through pino - #153

Merged
buzz-code merged 1 commit into
mainfrom
claude/dokploy-logs-management-rszzop
Aug 23, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/dokploy-logs-management-rszzop

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

What

Bumps server/shared to nra-server#41 (merged as 1bdb729), follow-up to the request-id/500-logging work in nra-server#40 (already bumped in #149).

A real production log line surfaced that TypeORM's own query logs (logging: "all") go through TypeORM's built-in console logger, not pino - so they never carried req.id, even for a query fired during a request. TypeOrmPinoLogger now routes them through the same DI-resolved pino Logger used everywhere else, wired in setupApplication (already called from server/src/main.ts) - no app-side changes needed.

  • Query fired during an HTTP request → now carries that request's req.id.
  • Query fired outside one (migrations, the schedule-heartbeat cron) → falls back to the plain root logger, same as any other out-of-request log call.

Purely a transport change - database.config.ts's logging option still governs what TypeORM logs, this only changes where those calls go.

Testing

cd server && yarn test - 998/998 passing, against the real bumped submodule.


Generated by Claude Code

Picks up nra-server#41: TypeOrmPinoLogger wraps the same DI-resolved
Logger already wired for HTTP request logging, so a query fired during
a request now carries req.id too - a query outside one (migrations,
the schedule heartbeat cron) falls back to the plain root logger, same
as any other out-of-request log call. No app-side changes needed.
Copilot AI lite review requested due to automatic review settings August 23, 2026 19:20
@buzz-code
buzz-code merged commit 1e7a7ee into main Aug 23, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

No final review comments or reviewed files were supplied.

Pull request overview

Bumps server/shared to route TypeORM logs through the pino logger with request-ID correlation.

Changes:

  • Updates the shared server submodule.
  • Adds TypeORM logging integration and tests.
File summaries
File Description
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants