Repository navigation
Bump server/shared: TypeORM query logs now route through pino - #153
Merged
Merged
Conversation
Picks up nra-server#41: TypeOrmPinoLogger wraps the same DI-resolved Logger already wired for HTTP request logging, so a query fired during a request now carries req.id too - a query outside one (migrations, the schedule heartbeat cron) falls back to the plain root logger, same as any other out-of-request log call. No app-side changes needed.
There was a problem hiding this comment.
🔵 Needs a closer look
No final review comments or reviewed files were supplied.
Pull request overview
Bumps server/shared to route TypeORM logs through the pino logger with request-ID correlation.
Changes:
- Updates the shared server submodule.
- Adds TypeORM logging integration and tests.
File summaries
| File | Description |
|---|
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
server/sharedto nra-server#41 (merged as1bdb729), follow-up to the request-id/500-logging work in nra-server#40 (already bumped in #149).A real production log line surfaced that TypeORM's own query logs (
logging: "all") go through TypeORM's built-in console logger, not pino - so they never carriedreq.id, even for a query fired during a request.TypeOrmPinoLoggernow routes them through the same DI-resolved pinoLoggerused everywhere else, wired insetupApplication(already called fromserver/src/main.ts) - no app-side changes needed.req.id.Purely a transport change -
database.config.ts'sloggingoption still governs what TypeORM logs, this only changes where those calls go.Testing
cd server && yarn test- 998/998 passing, against the real bumped submodule.Generated by Claude Code