Repository navigation
Conversation
The GRANT SYSTEM_USER statement hardcoded 'mysql_user' as the
username, breaking any fresh install that uses a different
MYSQL_USER value (fails with 'You are not allowed to create a
user with GRANT' on MySQL 8.4 since that literal user doesn't
exist).
db/init-grants.sh already does this exact grant correctly and
dynamically via ${MYSQL_USER}, so the line in data.sql was both
redundant and the actual cause of the bug. Removing it lets a
fresh install use any DB username.
Extracted the database+phpmyadmin services from the root docker-compose.yml into their own file, meant to be deployed once and shared across every app instead of bundling a dedicated MySQL into each app's own stack. Reaches consumers over the external dokploy-network.
There was a problem hiding this comment.
Pull request overview
Add standalone db/docker-compose.yml for deploying MySQL + phpMyAdmin as shared service on dokploy-network, separate from app stack.
Changes:
- Add new compose file under
db/for standalone DB deployment - Configure MySQL + phpMyAdmin to join external
dokploy-network
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3
to
+7
| # Standalone MySQL + phpMyAdmin, meant to be deployed on its own (not | ||
| # bundled into an app's stack) and shared across every app that needs it. | ||
| # Each app gets its own database + dedicated user created on this one | ||
| # server (see README below) and reaches it over the `dokploy-network` | ||
| # external network. |
Comment on lines
+12
to
+14
| build: | ||
| context: . | ||
| cap_add: |
Mirrors docker-compose-swarm.yml (client+server, prebuilt ghcr images) but targets dokploy-network instead of the Coolify-specific caddy/elknet/private-network/backend-network networks, so it can be deployed via Dokploy's git-based compose without editing (and risking) the file the existing Coolify deployment relies on.
The client container was reporting unhealthy indefinitely -- nginx's own access log never showed a single hit from the healthcheck itself, meaning the wget exec was failing before ever reaching nginx, not after. Docker-unhealthy containers get excluded from Traefik's routing pool entirely, which is why the client's domain returned a bare 404 with no route at all, unlike the server (healthy, routed fine).
buzz-code
pushed a commit
that referenced
this pull request
Sep 4, 2026
…nv var set, fix dokploy CI trigger to single compose.deploy call - Cherry-picked PR #148's commits (db/docker-compose.yml, docker-compose-dokploy.yml, data.sql GRANT fix, client healthcheck fix) onto this branch without merging main, since that PR is still open. - Added the env vars actual app code reads but weren't wired anywhere: MYSQL_PORT, NODE_ENV, PORT, WORKER_ENABLED, JOB_POLL_MS, JOB_WORKER_BATCH, MAIL_WEBHOOK_SECRET, YEMOT_LEGACY_ROUTE_DEADLINE, IP_ADDRESS, S3_* (found via process.env grep across server + server/shared). - Replaced the guessed DOKPLOY_CLIENT_WEBHOOK/DOKPLOY_SERVER_WEBHOOK secrets with a single dokploy API call (compose.deploy) against the one compose stack that already runs client+server together, using a DOKPLOY_API_KEY secret. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019uTSUALnwT3fCG2vCC8SM4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
db/docker-compose.yml— just thedatabase+phpmyadminservices, pulled out of the rootdocker-compose.yml, meant to be deployed on its own and shared by every app instead of each app bundling its own dedicated MySQL.Why
Came out of deploying
attendanceon Dokploy: baking adatabaseservice into the app's own compose stack means every app gets its own MySQL container, which isn't what's wanted when the goal is one shared MySQL server that all apps connect to (each with its own database + dedicated user on that one server, same as the existing per-project MySQL convention documented inmulti-repo-codespace'srun-without-dockerskill).This deploys independently, and other apps' compose stacks reach it over the external
dokploy-networkby itsdatabasecontainer name.Notes for review
docker-compose.yml/docker-compose-swarm.ymlare untouched — this is purely additive, doesn't change how anyone currently deploys the full bundled stack.dokploy-network(Dokploy's shared network) rather than the Coolify-specificcaddy/elknet/private-networknetworks the root compose files use, since this is for the Dokploy deployment path.container_name: databaseis hardcoded here (matching the root compose's convention). Fine as the only "database"-named container ondokploy-networktoday, but a second compose stack that also declares its owndatabasecontainer joining the same shared network would collide — worth a naming convention once there's an actual second consumer.Generated by Claude Code