Repository navigation
Academic year start Aug 1 + seminar-attendance IVR fixes - #138
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MX2QnzzPvash7UmemgUPL9
…ance call - Greets teacher by name at call start - Confirms klass name/number after manual klass entry - Fix howManyLessons staying null/0 on seminar attendance AttReport rows, breaking report calculations Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MX2QnzzPvash7UmemgUPL9
…n seminar tests Adds entersKlass() (klass entry + confirmation) and startsSeminarCall() (greeting + klass entry) helpers, replacing the same 2-3 line block that was repeated across most seminar-attendance test cases. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MX2QnzzPvash7UmemgUPL9
There was a problem hiding this comment.
Pull request overview
Update server seminar-attendance Yemot IVR flow + persistence so downstream attendance reports get correct lesson-count math.
Changes:
- Add teacher greeting (
SEMINAR.WELCOME) at seminar call start; add klass confirmation (SEMINAR.KLASS_CONFIRMED) after manual klass entry. - Set
AttReport.howManyLessons = 1per saved seminar-attendance row. - Add migration for new text keys; update tests with helpers +
howManyLessonsassertion.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/src/yemot-handler.service.ts | Add new IVR messages for seminar flow; persist howManyLessons on created AttReport rows. |
| server/src/yemot-handler.service.test.ts | Add seeded texts + scenario helpers; assert howManyLessons set to 1. |
| server/src/migrations/1787002860064-UpdateYemotTextsWelcomeAndKlassConfirm.ts | Insert new Yemot text keys for welcome + klass confirmation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server/sharedsubmodule pointer to pick up the academic-year-start change (Sept 1 → Aug 1) fromnra-server#36.SEMINAR.WELCOME) at call start, and confirm the klass name (SEMINAR.KLASS_CONFIRMED) after manual klass-number entry.howManyLessonsstaying null/0 on seminar-attendanceAttReportrows — now set to1per saved row, since each call covers one lesson session. Was silently breaking downstream report calculations that divide by lesson count.1787002860064-UpdateYemotTextsWelcomeAndKlassConfirm.tsfor the two new text keys.welcomesTeacher/askForKlass/confirmsKlassscenario-step sequences inyemot-handler.service.test.tsintoentersKlass()/startsSeminarCall()helpers.Testing
Full server suite: 100 suites / 941 tests passing (
cd server && yarn test, aftergit submodule update --init server/shared+yarn install).🤖 Generated with Claude Code
Generated by Claude Code