Skip to content

Academic year start Aug 1 + seminar-attendance IVR fixes - #138

Merged
buzz-code merged 3 commits into
mainfrom
claude/year-start-august-s6zrjt
Aug 18, 2026
Merged

buzz-code merged 3 commits into
mainfrom
claude/year-start-august-s6zrjt

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Bump server/shared submodule pointer to pick up the academic-year-start change (Sept 1 → Aug 1) from nra-server#36.
  • Seminar-attendance Yemot call: greet the teacher by name (SEMINAR.WELCOME) at call start, and confirm the klass name (SEMINAR.KLASS_CONFIRMED) after manual klass-number entry.
  • Fix howManyLessons staying null/0 on seminar-attendance AttReport rows — now set to 1 per saved row, since each call covers one lesson session. Was silently breaking downstream report calculations that divide by lesson count.
  • Added migration 1787002860064-UpdateYemotTextsWelcomeAndKlassConfirm.ts for the two new text keys.
  • Deduped repeated welcomesTeacher/askForKlass/confirmsKlass scenario-step sequences in yemot-handler.service.test.ts into entersKlass()/startsSeminarCall() helpers.

Testing

Full server suite: 100 suites / 941 tests passing (cd server && yarn test, after git submodule update --init server/shared + yarn install).


🤖 Generated with Claude Code


Generated by Claude Code

claude added 3 commits August 17, 2026 20:01
…ance call

- Greets teacher by name at call start
- Confirms klass name/number after manual klass entry
- Fix howManyLessons staying null/0 on seminar attendance AttReport rows, breaking report calculations

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MX2QnzzPvash7UmemgUPL9
…n seminar tests

Adds entersKlass() (klass entry + confirmation) and startsSeminarCall()
(greeting + klass entry) helpers, replacing the same 2-3 line block that
was repeated across most seminar-attendance test cases.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MX2QnzzPvash7UmemgUPL9
Copilot AI lite review requested due to automatic review settings August 18, 2026 05:39
@buzz-code
buzz-code merged commit 0da364e into main Aug 18, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Update server seminar-attendance Yemot IVR flow + persistence so downstream attendance reports get correct lesson-count math.

Changes:

  • Add teacher greeting (SEMINAR.WELCOME) at seminar call start; add klass confirmation (SEMINAR.KLASS_CONFIRMED) after manual klass entry.
  • Set AttReport.howManyLessons = 1 per saved seminar-attendance row.
  • Add migration for new text keys; update tests with helpers + howManyLessons assertion.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
server/src/yemot-handler.service.ts Add new IVR messages for seminar flow; persist howManyLessons on created AttReport rows.
server/src/yemot-handler.service.test.ts Add seeded texts + scenario helpers; assert howManyLessons set to 1.
server/src/migrations/1787002860064-UpdateYemotTextsWelcomeAndKlassConfirm.ts Insert new Yemot text keys for welcome + klass confirmation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants