Skip to content

chore: bump server/shared and client/shared refs (Yemot/mail webhook auth) - #137

Merged
buzz-code merged 5 commits into
mainfrom
claude/bump-shared-refs-yemot-auth
Sep 22, 2026
Merged

buzz-code merged 5 commits into
mainfrom
claude/bump-shared-refs-yemot-auth

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

Pointer-only bump of both shared submodules, picking up the open-endpoint auth work merged in nra-server/nra-client:

  • server/shared → nra-server#35: MailWebhookGuard on handle-email (checks X-Webhook-Secret against MAIL_WEBHOOK_SECRET, no-op until set), per-user Yemot webhook token + secured /yemot/handle-call/:secret route, YEMOT_LEGACY_ROUTE_DEADLINE cutoff for the legacy route (unset by default).
  • client/shared → nra-client#41: Yemot migration banner (nags users still on the legacy URL, with a countdown once a deadline is configured) + Tutorial.jsx showing the user's personal webhook link.

No code changes needed in this repo — both are backward compatible by design (gated on unset env vars / unmatched secrets), and the client banner wires in automatically via the shared Layout.

Follow-up (ops, not code)

  • Set MAIL_WEBHOOK_SECRET in server/.env and point n8n's handle-email request at the X-Webhook-Secret header.
  • Optionally set YEMOT_LEGACY_ROUTE_DEADLINE once ready to sunset the old Yemot URL.

Verification

This was the primary verification bed for the underlying nra-server/nra-client changes: full server suite (940/940, including a new e2e suite exercising the real Express + yemot-router2 wiring over HTTP) and the touched client suites, all green before those PRs merged. This bump checks out the exact same, now-merged commits — confirmed byte-identical to what was tested.


Generated by Claude Code

Picks up:
- server/shared: MailWebhookGuard on handle-email, per-user Yemot webhook
  token + secured route, YEMOT_LEGACY_ROUTE_DEADLINE cutoff (nra-server#35)
- client/shared: Yemot migration banner + Tutorial.jsx personal link and
  cutoff countdown (nra-client#41)

No code changes needed here - both are backward compatible, gated on unset
env vars / unmatched secrets. Follow-up ops task: set MAIL_WEBHOOK_SECRET in
server/.env and point n8n's handle-email request at the X-Webhook-Secret
header.
Copilot AI lite review requested due to automatic review settings August 17, 2026 20:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bump server/shared + client/shared submodule refs to pick up webhook auth hardening (mail webhook secret header, Yemot per-user secret route + legacy cutoff support) plus client-side migration UX (banner + tutorial link).

Changes:

  • Update server/shared ref to include MailWebhookGuard for handle-email, Yemot secured route, legacy-route deadline gating
  • Update client/shared ref to include Yemot migration banner + tutorial page webhook link

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
server/shared Pull in shared NestJS changes for mail webhook header secret guard + Yemot secured webhook route support
client/shared Pull in shared React-Admin UI changes for Yemot migration banner + tutorial webhook link

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

claude added 4 commits August 18, 2026 05:30
…er-compose

Both are new server env vars from the shared/ bump but weren't passed
through to the container - docker-compose only forwards vars explicitly
listed in the environment: block, there's no env_file passthrough here.
Without this, setting them in .env alone does nothing.

Still needs, on the actual deploy host (not in this repo, .env is
gitignored):
  MAIL_WEBHOOK_SECRET=<random>
  YEMOT_LEGACY_ROUTE_DEADLINE=2026-09-15
…template

Same two vars just wired into docker-compose, now documented where the
setup file actually lists what .env needs.
@buzz-code
buzz-code merged commit a03de0d into main Sep 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants