Repository navigation
chore: bump server/shared and client/shared refs (Yemot/mail webhook auth) - #137
Merged
Merged
Conversation
Picks up: - server/shared: MailWebhookGuard on handle-email, per-user Yemot webhook token + secured route, YEMOT_LEGACY_ROUTE_DEADLINE cutoff (nra-server#35) - client/shared: Yemot migration banner + Tutorial.jsx personal link and cutoff countdown (nra-client#41) No code changes needed here - both are backward compatible, gated on unset env vars / unmatched secrets. Follow-up ops task: set MAIL_WEBHOOK_SECRET in server/.env and point n8n's handle-email request at the X-Webhook-Secret header.
There was a problem hiding this comment.
Pull request overview
Bump server/shared + client/shared submodule refs to pick up webhook auth hardening (mail webhook secret header, Yemot per-user secret route + legacy cutoff support) plus client-side migration UX (banner + tutorial link).
Changes:
- Update
server/sharedref to includeMailWebhookGuardforhandle-email, Yemot secured route, legacy-route deadline gating - Update
client/sharedref to include Yemot migration banner + tutorial page webhook link
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/shared | Pull in shared NestJS changes for mail webhook header secret guard + Yemot secured webhook route support |
| client/shared | Pull in shared React-Admin UI changes for Yemot migration banner + tutorial webhook link |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…er-compose Both are new server env vars from the shared/ bump but weren't passed through to the container - docker-compose only forwards vars explicitly listed in the environment: block, there's no env_file passthrough here. Without this, setting them in .env alone does nothing. Still needs, on the actual deploy host (not in this repo, .env is gitignored): MAIL_WEBHOOK_SECRET=<random> YEMOT_LEGACY_ROUTE_DEADLINE=2026-09-15
…template Same two vars just wired into docker-compose, now documented where the setup file actually lists what .env needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pointer-only bump of both shared submodules, picking up the open-endpoint auth work merged in
nra-server/nra-client:server/shared→nra-server#35:MailWebhookGuardonhandle-email(checksX-Webhook-SecretagainstMAIL_WEBHOOK_SECRET, no-op until set), per-user Yemot webhook token + secured/yemot/handle-call/:secretroute,YEMOT_LEGACY_ROUTE_DEADLINEcutoff for the legacy route (unset by default).client/shared→nra-client#41: Yemot migration banner (nags users still on the legacy URL, with a countdown once a deadline is configured) +Tutorial.jsxshowing the user's personal webhook link.No code changes needed in this repo — both are backward compatible by design (gated on unset env vars / unmatched secrets), and the client banner wires in automatically via the shared
Layout.Follow-up (ops, not code)
MAIL_WEBHOOK_SECRETinserver/.envand point n8n'shandle-emailrequest at theX-Webhook-Secretheader.YEMOT_LEGACY_ROUTE_DEADLINEonce ready to sunset the old Yemot URL.Verification
This was the primary verification bed for the underlying
nra-server/nra-clientchanges: full server suite (940/940, including a new e2e suite exercising the real Express +yemot-router2wiring over HTTP) and the touched client suites, all green before those PRs merged. This bump checks out the exact same, now-merged commits — confirmed byte-identical to what was tested.Generated by Claude Code