Skip to content

Bump client/shared: narrow crash detection to react-admin's error fallback - #136

Merged
buzz-code merged 1 commit into
mainfrom
claude/docs-test-coverage-projects-6ex6b1
Aug 15, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/docs-test-coverage-projects-6ex6b1

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

Bumps client/shared to nra-client@9f10925. A bare [role="alert"] (used by entities.test.js's crash detection, added in #135) also matches an ordinary MUI <Alert> or a validation-message live region a page can legitimately render without having crashed — a latent false-positive risk, flagged by Copilot review on dnd-management-nra#95's equivalent bump. The check now looks specifically for the <h1 role="alert"> react-admin's <Error> fallback renders (ra-ui-materialui's Error.tsx).

Testing

Re-ran the injected-unimported-function verification from #135: create and edit phases still fail naming exactly /student/create and /student/1, nothing else. entities.test.js passes clean, 10/10.


Generated by Claude Code

…lback

Picks up nra-client@9f10925. A bare [role="alert"] also matches an
ordinary MUI <Alert> or a validation-message live region a page can
legitimately render without having crashed — flagged by Copilot review
on dnd-management-nra#95. Now checks specifically for the <h1
role="alert"> react-admin's <Error> fallback renders.

Verified no regression: re-ran the injected-unimported-function check —
create and edit phases still fail naming exactly /student/create and
/student/1, nothing else.
Copilot AI lite review requested due to automatic review settings August 15, 2026 19:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bump client/shared submodule to nra-client@9f10925, tightening jsdom resource smoke-test crash signal to react-admin error fallback heading, avoiding false positives from normal MUI <Alert> / live regions.

Changes:

  • Update crash detection selector from bare [role="alert"] to h1[role="alert"] (react-admin <Error> fallback).
  • Keep resource smoke-test flow same, only tighten failure condition.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@buzz-code
buzz-code merged commit da2c74d into main Aug 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants