Repository navigation
Bump client/shared: narrow crash detection to react-admin's error fallback - #136
Merged
Merged
Conversation
…lback Picks up nra-client@9f10925. A bare [role="alert"] also matches an ordinary MUI <Alert> or a validation-message live region a page can legitimately render without having crashed — flagged by Copilot review on dnd-management-nra#95. Now checks specifically for the <h1 role="alert"> react-admin's <Error> fallback renders. Verified no regression: re-ran the injected-unimported-function check — create and edit phases still fail naming exactly /student/create and /student/1, nothing else.
There was a problem hiding this comment.
Pull request overview
Bump client/shared submodule to nra-client@9f10925, tightening jsdom resource smoke-test crash signal to react-admin error fallback heading, avoiding false positives from normal MUI <Alert> / live regions.
Changes:
- Update crash detection selector from bare
[role="alert"]toh1[role="alert"](react-admin<Error>fallback). - Keep resource smoke-test flow same, only tighten failure condition.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
client/sharedtonra-client@9f10925. A bare[role="alert"](used byentities.test.js's crash detection, added in #135) also matches an ordinary MUI<Alert>or a validation-message live region a page can legitimately render without having crashed — a latent false-positive risk, flagged by Copilot review ondnd-management-nra#95's equivalent bump. The check now looks specifically for the<h1 role="alert">react-admin's<Error>fallback renders (ra-ui-materialui'sError.tsx).Testing
Re-ran the injected-unimported-function verification from #135: create and edit phases still fail naming exactly
/student/createand/student/1, nothing else.entities.test.jspasses clean, 10/10.Generated by Claude Code