Repository navigation
Move sqlite3 to devDependencies - #133
Merged
Merged
Conversation
sqlite3 is only used in server/src/__tests__ (in-memory test DB), never at runtime. Listed under dependencies it forced the production Docker stage (yarn install --production) to compile its native binding via node-gyp, which fails there. Moving it to devDependencies makes --production skip it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017jjJVx8ymZqxJjPtHHc6hS
There was a problem hiding this comment.
Pull request overview
Move sqlite3 from runtime dependencies to devDependencies in server package, so production install (yarn install --production) skips native node-gyp build. Fits server build/deploy pipeline, keeps SQLite driver only for Jest/E2E in-memory DB.
Changes:
- Remove
sqlite3fromdependencies. - Add
sqlite3todevDependenciesfor test-only TypeORM SQLite usage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlite3is only used inserver/src/__tests__(in-memory test DB), never at runtime. Listed underdependenciesit forced the production Docker stage (yarn install --production) to compile its native binding vianode-gyp, which fails there:Moving it to
devDependenciesmakes--productionskip it entirely.🤖 Generated with Claude Code
Generated by Claude Code