Repository navigation
Add contact page with mail-based submission and file attachments - #131
Merged
Merged
Conversation
Bumps client/shared and server/shared to pull in the new public /contact page (ContactPage.jsx) and the matching server POST /contact endpoint, which emails submissions to yomanet.office@gmail.com. Wires a '\''צור קשר'\'' menu item into the sidebar for logged-in users; anonymous users reach the same page via links on the login/home pages. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RHpQm3g8f6DWciZTjNG7Fr
Internal refactor only (PUBLIC_ROUTE_PATHS extracted to utils/publicRoutes.js) - no consumer action needed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RHpQm3g8f6DWciZTjNG7Fr
Points both submodules at their merged main commits (nra-client PR #38, nra-server PR #31) now that the shared contact-page/endpoint change has landed on main, instead of the feature branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RHpQm3g8f6DWciZTjNG7Fr
There was a problem hiding this comment.
Pull request overview
Add UI entrypoints for new /contact feature in React-Admin app (menu + roadmap), aligning client shell with contact page + submission flow pulled via shared submodules.
Changes:
- Add sidebar menu item "צור קשר" linking to
/contactfor standard-view logged-in users - Add roadmap item marking contact page (with attachments) as completed
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/src/GeneralLayout.jsx | Add /contact MenuItemLink with ContactMail icon for standard-view users |
| client/src/roadmapFeatures.js | Add roadmap entry for contact page with attachments |
Files not reviewed (1)
- client/src/roadmapFeatures.js: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dorny/paths-filter queries the GitHub API to list a PR's changed files; without pull-requests:read the default GITHUB_TOKEN gets 'Resource not accessible by integration'. dnd-management-nra's workflow already has this permissions block - mirrors it here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RHpQm3g8f6DWciZTjNG7Fr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client/shared(nra-client #38) andserver/shared(nra-server #31) to pull in the new public/contactpage and matchingPOST /contactendpoint, which emails submissions toyomanet.office@gmail.com.GeneralLayout.jsx) for logged-in users; anonymous users reach the same page via links on the login/home pages.Testing
cd server && yarn test— 919/919 passingcd client && yarn test— 184/184 passing🤖 Generated with Claude Code
Generated by Claude Code