Repository navigation
Fix overlapping header rows in attendance table - #129
Merged
Merged
Conversation
The two sticky header rows (dates/lesson-info, then column labels) both anchored to top:0, so once scrolled they collided instead of stacking - the shorter column-labels row would render on top of the taller row above it, which then bled into the first student row. The first row's height varies with which optional fields are shown, so it's measured at runtime and used as the second row's sticky top offset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
top: 0, so once scrolled they collided instead of stacking - the shorter column-labels row rendered on top of the taller row above it, which then bled into the first student row.ResizeObserver) and applied as the second row's stickytopoffset.Test plan
yarn testinclient- 177 tests passingGenerated by Claude Code