Repository navigation
Add per-date lesson count override for in-lesson reports - #128
Merged
Merged
Conversation
- Per-date "howManyLessons" override in attendance form, gated behind new perDateLessonCount permission; falls back to shared value. - Fix attendance table sticky header/first column not actually sticking (TableContainer had no bounded height, so position:sticky never engaged) by bounding maxHeight and pinning the student-name column. - Restore lesson name column in sessions summary report (data was already fetched, just commented out in the render).
left:0 only pins the column to the physical left edge, which is wrong in RTL layouts where the name column sits on the right. insetInlineStart resolves to the correct physical side per the active theme direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable teachers with
perDateLessonCountpermission to override lesson count per report date instead of using single global value.Changes:
perDateLessonCountpermission toappPermissionsand createuseIsPerDateLessonCount()hookNumberInputfield in report date headers to setlessonDetails[index].howManyLessonswhen permission grantedhowManyLessonsImplementation details:
lessonDetails[index].howManyLessonshttps://claude.ai/code/session_01B1NERKv7WYgToYwbg7WGYX