Repository navigation
Exclude signatureData when report_group_session joins reportGroup - #126
Merged
Merged
Conversation
Same bloat as report_group's list endpoint, different door: excluding signatureData from ReportGroup's own CRUD config doesn't cover it being pulled in as a joined relation from a sibling entity. Every report_group_session list request with join[]=reportGroup (the normal session-list filter/sort view) was dragging the full base64 signature image along for each row. @dataui/crud's JoinOption has its own exclude, same mechanism as the entity-level fix, just needs setting at the join site too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
report_group_sessionlist requests (join[]=reportGroup, the normal session filter/sort view) were still pulling the full base64signatureDataimage for every row - excluding it fromreport_group's own CRUD config doesn't cover it being pulled in as a joined relation from a sibling entity's endpoint.@dataui/crud's per-joinexcludeoption (server/src/entity-modules/report-group-session.config.ts), same mechanism as the earlierreport_groupfix, just declared at the join site.reportGroup. The only other reads ofreportGroup.signatureDataare direct repository queries in two report generators, which bypass the CRUD builder and correctly still get the real signature.Test plan
yarn test- 912/912 passingGenerated by Claude Code