Skip to content

Exclude signatureData when report_group_session joins reportGroup - #126

Merged
buzz-code merged 1 commit into
mainfrom
claude/api-response-performance-1snxv1
Jul 19, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/api-response-performance-1snxv1

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • report_group_session list requests (join[]=reportGroup, the normal session filter/sort view) were still pulling the full base64 signatureData image for every row - excluding it from report_group's own CRUD config doesn't cover it being pulled in as a joined relation from a sibling entity's endpoint.
  • Fixed with @dataui/crud's per-join exclude option (server/src/entity-modules/report-group-session.config.ts), same mechanism as the earlier report_group fix, just declared at the join site.
  • Checked for other exposure: no other CRUD config joins reportGroup. The only other reads of reportGroup.signatureData are direct repository queries in two report generators, which bypass the CRUD builder and correctly still get the real signature.

Test plan

  • yarn test - 912/912 passing

Generated by Claude Code

Same bloat as report_group's list endpoint, different door: excluding
signatureData from ReportGroup's own CRUD config doesn't cover it
being pulled in as a joined relation from a sibling entity. Every
report_group_session list request with join[]=reportGroup (the normal
session-list filter/sort view) was dragging the full base64 signature
image along for each row.

@dataui/crud's JoinOption has its own exclude, same mechanism as the
entity-level fix, just needs setting at the join site too.
@buzz-code
buzz-code merged commit f8c6816 into main Jul 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants