Repository navigation
Update client/shared to nra-client's latest main - #122
Merged
Merged
Conversation
- Bump client/shared to nra-client's fix for the AppBar user menu: shows the signed-in user's initials in the avatar instead of a generic person icon on narrow screens, where react-admin's tooltip fallback otherwise hardcodes the untranslated "Profile" label. - Override PhoneSettingsInput's subtitle: this app uses User.phoneNumber to identify incoming Yemot calls (matched against call.did), not for sending outbound messages, so the previous "for sending messages" description was misleading here.
Bump client/shared to nra-client's fix for the default subtitle text, and drop the local override in Settings.jsx now that the shared default is correct for this app too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client/sharedsubmodule to nra-client's latestmain(Correct default phone number subtitle text nra-client#33), which correctsPhoneSettingsInput's default subtitle to describe the number as the account's registered Yemot number instead of the previous "for sending messages" text.Test plan
yarn testin client passes (27 suites, 177 tests)yarn buildin client passesyarn buildin server passesGenerated by Claude Code