Skip to content

Fix year filter showing a blank checkbox in every list's "add filter" menu - #116

Merged
buzz-code merged 1 commit into
mainfrom
claude/peaceful-keller-y0d99n
Jul 15, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/peaceful-keller-y0d99n

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Bumps client/shared to nra-client main (Fix year filter showing a blank checkbox in every list's "add filter" menu nra-client#28), which fixes CommonYearInputFilter: react-admin's FilterButtonMenuItem reads source/label directly off the unrendered filter element, but CommonYearInputFilter only set source="year" inside its own render body - so every list using it showed a blank, unlabeled checkbox for the year filter in the "add filter" menu, even though the same year column header and applied filter worked fine
  • Affects ~19 entity/pivot list files in this app (lesson, att_report, klass, grade, and others)
  • Reported from a real screenshot of this app

Test plan

  • yarn test --watchAll=false in client - 25 suites / 163 tests passing

Generated by Claude Code

@buzz-code
buzz-code merged commit 1e594b4 into main Jul 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants