Skip to content

Fix missing phoneNumber/yemotApiKey translations in Settings - #113

Merged
buzz-code merged 1 commit into
mainfrom
claude/peaceful-keller-y0d99n
Jul 14, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/peaceful-keller-y0d99n

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Reported from a real screenshot: the "מספר טלפון" field in Settings showed the raw key resources.settings.fields.phoneNumber as its label instead of a translated string, and the same for the Yemot API key field
  • Root cause: PhoneSettingsInput/YemotSettingsInput (shared, nra-client) pass an explicit translation-key string as label, but neither phoneNumber nor yemotApiKey existed under resources.settings.fields in this app's domainTranslations.js - react-admin doesn't fall back to humanizing an explicit label the way it does for auto-derived ones, so the raw key rendered verbatim
  • Audited every other field on the Settings page for the same issue - everything else either uses label={false} or an auto-derived label that already resolves correctly (e.g. reportCardSettings.attendance → "הצג נוכחות")
  • Also removed dashboardItems.resource/yearFilterType/filter/title, reportStyles.type/fontFamily/fontSize/isBold/isItalic, and reportCardSettings.debug - dead translation entries for fields removed in the earlier settings redesign, confirmed unreferenced anywhere else in the codebase

Note: the "adminUser" text visible in the original screenshot's phone field is that user's actual stored phoneNumber value (real data), not a code issue - editing and saving the field will correct it.

Test plan

  • yarn test --watchAll=false in client - 25 suites / 160 tests passing
  • Manual verification via Vite + Playwright: both fields now show their correct Hebrew labels ("מספר טלפון" / "מפתח API של Yemot") instead of the raw translation key, no console errors

Generated by Claude Code

PhoneSettingsInput and YemotSettingsInput (nra-client, shared) pass
explicit translation-key labels ("resources.settings.fields.phoneNumber"
/ "...yemotApiKey"), but neither key existed in this app's
domainTranslations.js - react-admin has no fallback humanization for
explicit string labels, so the raw key rendered verbatim instead of a
label.

Also drops dashboardItems.resource/yearFilterType/filter/title and
reportStyles.type/fontFamily/fontSize/isBold/isItalic and
reportCardSettings.debug - dead entries left over from fields removed
earlier in the settings redesign (verified unreferenced anywhere else).
@buzz-code
buzz-code merged commit 01a6a85 into main Jul 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants