Repository navigation
Fix missing phoneNumber/yemotApiKey translations in Settings - #113
Merged
Merged
Conversation
PhoneSettingsInput and YemotSettingsInput (nra-client, shared) pass
explicit translation-key labels ("resources.settings.fields.phoneNumber"
/ "...yemotApiKey"), but neither key existed in this app's
domainTranslations.js - react-admin has no fallback humanization for
explicit string labels, so the raw key rendered verbatim instead of a
label.
Also drops dashboardItems.resource/yearFilterType/filter/title and
reportStyles.type/fontFamily/fontSize/isBold/isItalic and
reportCardSettings.debug - dead entries left over from fields removed
earlier in the settings redesign (verified unreferenced anywhere else).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resources.settings.fields.phoneNumberas its label instead of a translated string, and the same for the Yemot API key fieldPhoneSettingsInput/YemotSettingsInput(shared,nra-client) pass an explicit translation-key string aslabel, but neitherphoneNumbernoryemotApiKeyexisted underresources.settings.fieldsin this app'sdomainTranslations.js- react-admin doesn't fall back to humanizing an explicit label the way it does for auto-derived ones, so the raw key rendered verbatimlabel={false}or an auto-derived label that already resolves correctly (e.g.reportCardSettings.attendance→ "הצג נוכחות")dashboardItems.resource/yearFilterType/filter/title,reportStyles.type/fontFamily/fontSize/isBold/isItalic, andreportCardSettings.debug- dead translation entries for fields removed in the earlier settings redesign, confirmed unreferenced anywhere else in the codebaseNote: the "adminUser" text visible in the original screenshot's phone field is that user's actual stored
phoneNumbervalue (real data), not a code issue - editing and saving the field will correct it.Test plan
yarn test --watchAll=falseinclient- 25 suites / 160 tests passingGenerated by Claude Code