Repository navigation
Simplify report-style/dashboard settings, add add-to-dashboard flow - #112
Merged
Merged
Conversation
…urrent look Every icon in App.jsx (per-resource sidebar icons) and GeneralLayout.jsx (custom menu items and group icons) switches from Material's default Filled variant to Outlined - same icons, thinner stroke weight, matches the Outlined icons now used by nra-client's own Dashboard/Menu/SubMenu components so the whole sidebar reads as one consistent set instead of mixing weights.
- Reorder sections by how often a typical user touches them: general, phone, report-card design, report-card defaults, then an "advanced" group last (was: general, dashboard, report styles, report card defaults, phone, Yemot - roughly import order, not usage frequency). - Move dashboard-card config and the Yemot API key into a new "הגדרות מתקדמות" (advanced) section, since both are one-time setup usually done by an admin, not everyday settings. - Add helperText to every report-card toggle - none had any before, so field names like "forceAtt"/"hideAbsTotal" were unexplained. - Reword the dashboard filter field's label from "פילטר נוסף בפורמט JSON (אופציונלי, ללא שנה)" to "סינון מותאם אישית (מתקדם)" with a helperText explaining it's rarely needed. - Remove the "debug" report-card toggle. It defaulted to `true` for every school (getDefaultReportCardSettings), and reportGenerator.ts / studentReportCardReact.tsx read it to add an extra debug column to the actual printed/PDF report card - so this wasn't just a confusing toggle, schools that never touched this setting were printing debug output on real report cards sent to parents by default.
reportStyles: replace the free-form add-a-row-and-pick-a-type repeater with a fixed 6-row form, since the report card only ever has 6 style slots - there was never a real choice to make there. dashboardItems: drop the resource/yearFilterType/raw-filter-JSON fields in favor of a plain management view (rename, reorder, remove). Cards are now created from a list's own filter UI via the new AddToDashboardButton (nra-client), which produces valid values instead of asking users to type them blind. Also add helper text explaining lateValue's multiplier semantics, confirmed against its use in att-report.config.ts and the in-lesson report.
The submodule pointer was still on d852588, before CommonSettingsAccordion existed - Settings.jsx has depended on it since 97537b6, so this was only working in ad-hoc local checkouts, not the pinned commit. Bumped to 9c320f5 (adds CommonSettingsAccordion + AddToDashboardButton). ReportStylesInput: each style was a flex row that wrapped across 2-3 lines per entry. Switched to a real table so all 6 rows render as a single compact line each.
A blank fontFamily/fontSize doesn't mean "unset" - the server falls back per-field to defaultReportStyles in studentReportCardReact.tsx. Surface those real values as placeholders so users can see what they'll get before typing anything. Bump client/shared to cd21992 for the dashboard hint-text fix.
Grey placeholder text was too easy to miss (per user testing). Added a button that fills every blank field with the real report default (including isBold, which studentReportCardReact.tsx sets true for all headers/titles except tableCell) - only touches fields that are still empty, doesn't clobber anything the user already set. Also widened the fontSize column and centered its text - at 80px in RTL it was clipping two-digit values down to their last digit.
Bump client/shared to 48cadb9 (renames the sidebar label, page title, AddToDashboardButton's label/toast). Updates this app's own strings (settings section title/instructions, dashboardItems field translation) to match.
Bump client/shared to ab0e166. Also fixes a leftover "לוח מחוונים" in the advanced-settings subtitle missed in the earlier rename pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
debugreport-card toggle removed)lateValuenow has helper text explaining its multiplier semantics (confirmed againstatt-report.config.ts)ReportStylesInput) rebuilt as a fixed, compact single-row-per-style table with real per-type defaults shown as placeholders, plus a "טען ערכי ברירת מחדל" button to fill blanks with those defaults in one clickAddToDashboardButton, instead of hand-typing a resource/yearFilterType/JSON filterDashboardItemsInputfromnra-client(Modernize shared UI, redesign dashboard/settings, add shared DashboardItemsInput nra-client#26) instead of a local copyTest plan
yarn test --watchAll=falseinclient- 25 suites / 160 tests passing at each stepGenerated by Claude Code