Skip to content

Simplify report-style/dashboard settings, add add-to-dashboard flow - #112

Merged
buzz-code merged 9 commits into
mainfrom
claude/peaceful-keller-y0d99n
Jul 14, 2026
Merged

buzz-code merged 9 commits into
mainfrom
claude/peaceful-keller-y0d99n

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Sidebar icons switched from Filled to Outlined to match the shared theme refresh
  • Settings page reorganized (sections ordered by how often they're touched, subtitles added, advanced settings grouped, the unused debug report-card toggle removed)
  • lateValue now has helper text explaining its multiplier semantics (confirmed against att-report.config.ts)
  • עיצוב תעודה (ReportStylesInput) rebuilt as a fixed, compact single-row-per-style table with real per-type defaults shown as placeholders, plus a "טען ערכי ברירת מחדל" button to fill blanks with those defaults in one click
  • לוח מחוונים (dashboard settings) simplified to management-only (rename/reorder/remove) - cards are now created from a list's own filters via the new shared AddToDashboardButton, instead of hand-typing a resource/yearFilterType/JSON filter
  • Now consumes the shared DashboardItemsInput from nra-client (Modernize shared UI, redesign dashboard/settings, add shared DashboardItemsInput nra-client#26) instead of a local copy
  • Dashboard renamed "לוח המחוונים" → "תמונת מצב" throughout

Test plan

  • yarn test --watchAll=false in client - 25 suites / 160 tests passing at each step
  • Manual verification via Vite + Playwright against a mock backend: list → "הוסף לתמונת מצב" → card appears in Settings; Settings loads with no console errors; report-styles table renders and "load defaults" fills blank fields correctly

Generated by Claude Code

claude added 9 commits July 14, 2026 14:51
…urrent look

Every icon in App.jsx (per-resource sidebar icons) and GeneralLayout.jsx
(custom menu items and group icons) switches from Material's default
Filled variant to Outlined - same icons, thinner stroke weight, matches
the Outlined icons now used by nra-client's own Dashboard/Menu/SubMenu
components so the whole sidebar reads as one consistent set instead of
mixing weights.
- Reorder sections by how often a typical user touches them: general,
  phone, report-card design, report-card defaults, then an "advanced"
  group last (was: general, dashboard, report styles, report card
  defaults, phone, Yemot - roughly import order, not usage frequency).
- Move dashboard-card config and the Yemot API key into a new
  "הגדרות מתקדמות" (advanced) section, since both are one-time setup
  usually done by an admin, not everyday settings.
- Add helperText to every report-card toggle - none had any before,
  so field names like "forceAtt"/"hideAbsTotal" were unexplained.
- Reword the dashboard filter field's label from "פילטר נוסף בפורמט
  JSON (אופציונלי, ללא שנה)" to "סינון מותאם אישית (מתקדם)" with a
  helperText explaining it's rarely needed.
- Remove the "debug" report-card toggle. It defaulted to `true` for
  every school (getDefaultReportCardSettings), and reportGenerator.ts /
  studentReportCardReact.tsx read it to add an extra debug column to
  the actual printed/PDF report card - so this wasn't just a confusing
  toggle, schools that never touched this setting were printing debug
  output on real report cards sent to parents by default.
reportStyles: replace the free-form add-a-row-and-pick-a-type repeater
with a fixed 6-row form, since the report card only ever has 6 style
slots - there was never a real choice to make there.

dashboardItems: drop the resource/yearFilterType/raw-filter-JSON fields
in favor of a plain management view (rename, reorder, remove). Cards
are now created from a list's own filter UI via the new
AddToDashboardButton (nra-client), which produces valid values instead
of asking users to type them blind.

Also add helper text explaining lateValue's multiplier semantics,
confirmed against its use in att-report.config.ts and the in-lesson
report.
The submodule pointer was still on d852588, before CommonSettingsAccordion
existed - Settings.jsx has depended on it since 97537b6, so this was only
working in ad-hoc local checkouts, not the pinned commit. Bumped to
9c320f5 (adds CommonSettingsAccordion + AddToDashboardButton).

ReportStylesInput: each style was a flex row that wrapped across 2-3
lines per entry. Switched to a real table so all 6 rows render as a
single compact line each.
A blank fontFamily/fontSize doesn't mean "unset" - the server falls
back per-field to defaultReportStyles in studentReportCardReact.tsx.
Surface those real values as placeholders so users can see what they'll
get before typing anything.

Bump client/shared to cd21992 for the dashboard hint-text fix.
Grey placeholder text was too easy to miss (per user testing). Added a
button that fills every blank field with the real report default
(including isBold, which studentReportCardReact.tsx sets true for all
headers/titles except tableCell) - only touches fields that are still
empty, doesn't clobber anything the user already set.

Also widened the fontSize column and centered its text - at 80px in
RTL it was clipping two-digit values down to their last digit.
Bump client/shared to 48cadb9 (renames the sidebar label, page title,
AddToDashboardButton's label/toast). Updates this app's own strings
(settings section title/instructions, dashboardItems field translation)
to match.
Bump client/shared to ab0e166. Also fixes a leftover "לוח מחוונים"
in the advanced-settings subtitle missed in the earlier rename pass.
@buzz-code
buzz-code merged commit 2765448 into main Jul 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants