Skip to content

fix: use shared CommonPhoneResources instead of nonexistent 'phone' menu group - #106

Merged
buzz-code merged 1 commit into
mainfrom
claude/phone-tables-menu-org-ququf5
Jul 12, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/phone-tables-menu-org-ququf5

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • phone_template/phone_campaign were hand-rolled with menuGroup: 'phone', but no 'phone' group is defined in GeneralLayout's menuGroups, so they rendered as ungrouped top-level items instead of inside a submenu.
  • Switched to the shared CommonPhoneResources component (client/shared/components/app/CommonPhoneResources.jsx), already used correctly by dnd-management-nra, which places them under the existing settings group.
  • Removed now-unused imports (phoneCampaign, phoneTemplate, PhoneIcon, isPhoneCampaign).

Test plan

  • grep -n "menuGroup: 'phone'" client/src/App.jsx returns nothing.
  • Manual review confirms no orphaned imports remain.

Generated by Claude Code

…enu group

phone_template/phone_campaign were hand-rolled with menuGroup: 'phone', but
no 'phone' group is defined in GeneralLayout's menuGroups, so they rendered
as ungrouped top-level items. Switch to the shared CommonPhoneResources
component (already used correctly by dnd-management-nra), which places them
under the existing 'settings' group.
Copilot AI review requested due to automatic review settings July 12, 2026 19:33
@buzz-code
buzz-code merged commit c36fabc into main Jul 12, 2026
4 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the React-Admin menu grouping for the phone-related resources by replacing locally inlined phone_template / phone_campaign resources (previously assigned to a nonexistent menuGroup: 'phone') with the shared CommonPhoneResources helper, which places them under the existing settings menu group.

Changes:

  • Added CommonPhoneResources to the app’s resources list and removed the inlined phone_template / phone_campaign <Resource> definitions.
  • Removed now-unused imports (phoneCampaign, phoneTemplate, PhoneIcon, isPhoneCampaign) from client/src/App.jsx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants