Repository navigation
fix: use shared CommonPhoneResources instead of nonexistent 'phone' menu group - #106
Merged
Merged
Conversation
…enu group phone_template/phone_campaign were hand-rolled with menuGroup: 'phone', but no 'phone' group is defined in GeneralLayout's menuGroups, so they rendered as ungrouped top-level items. Switch to the shared CommonPhoneResources component (already used correctly by dnd-management-nra), which places them under the existing 'settings' group.
There was a problem hiding this comment.
Pull request overview
This PR fixes the React-Admin menu grouping for the phone-related resources by replacing locally inlined phone_template / phone_campaign resources (previously assigned to a nonexistent menuGroup: 'phone') with the shared CommonPhoneResources helper, which places them under the existing settings menu group.
Changes:
- Added
CommonPhoneResourcesto the app’s resources list and removed the inlinedphone_template/phone_campaign<Resource>definitions. - Removed now-unused imports (
phoneCampaign,phoneTemplate,PhoneIcon,isPhoneCampaign) fromclient/src/App.jsx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phone_template/phone_campaignwere hand-rolled withmenuGroup: 'phone', but no'phone'group is defined inGeneralLayout'smenuGroups, so they rendered as ungrouped top-level items instead of inside a submenu.CommonPhoneResourcescomponent (client/shared/components/app/CommonPhoneResources.jsx), already used correctly by dnd-management-nra, which places them under the existingsettingsgroup.phoneCampaign,phoneTemplate,PhoneIcon,isPhoneCampaign).Test plan
grep -n "menuGroup: 'phone'" client/src/App.jsxreturns nothing.Generated by Claude Code