Skip to content

Allow users to update their phone number in settings - #103

Merged
buzz-code merged 2 commits into
mainfrom
claude/phone-number-settings-update-62uj94
Jul 6, 2026
Merged

buzz-code merged 2 commits into
mainfrom
claude/phone-number-settings-update-62uj94

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Add PhoneSettingsInput to the settings page (client/src/settings/Settings.jsx), letting a logged-in user edit their phoneNumber.
  • Split the settings save handler: phoneNumber now goes through dataProvider.updateProfile (writes the top-level User.phoneNumber column via the new PATCH /profile endpoint), while the rest of the form still goes through dataProvider.updateSettings (writes to additionalData). These had to stay separate because phoneNumber is a real column used elsewhere (e.g. the Yemot IVR call router matches incoming calls against it), not just a preference blob.
  • Bump client/shared and server/shared to latest main, which include the new PhoneSettingsInput/dataProvider.updateProfile (Add phone number settings input nra-client#21) and AuthService.updateProfile/PATCH /profile (Add PATCH /profile endpoint for updating phone number nra-server#22), both already merged.
  • Add a roadmap entry.

Test plan

  • yarn test in client — 21 suites / 149 tests pass
  • yarn test in server — 877 tests pass (3 pre-existing unrelated failures from a missing @aws-sdk/client-s3 dependency)

Generated by Claude Code

claude added 2 commits July 6, 2026 09:47
Wires PhoneSettingsInput into Settings.jsx, saving via the new
dataProvider.updateProfile (separate from updateSettings, which only
persists to additionalData). Points client/shared and server/shared
at the phone-number-settings-update branches pending their PRs.
Copilot AI review requested due to automatic review settings July 6, 2026 15:29
@buzz-code
buzz-code merged commit 0cd365c into main Jul 6, 2026
3 of 4 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for editing a logged-in user’s phoneNumber from the client settings page, persisting it via a dedicated profile update path rather than the existing settings blob mechanism.

Changes:

  • Adds PhoneSettingsInput to the settings form and initializes phoneNumber from identity.phoneNumber.
  • Splits settings persistence so phoneNumber is saved via dataProvider.updateProfile, while other settings continue via dataProvider.updateSettings.
  • Updates the roadmap to mark phone-number updates in settings as completed.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
client/src/settings/Settings.jsx Adds phone number field to settings and saves it via updateProfile separately from updateSettings.
client/src/roadmapFeatures.js Adds a completed roadmap entry for updating phone number from settings.
Files not reviewed (1)
  • client/src/roadmapFeatures.js: Generated file

Comment on lines +46 to 50
const handleSave = async ({ phoneNumber, ...values }) => {
try {
await dataProvider.updateSettings({ data: values });
await dataProvider.updateProfile({ data: { phoneNumber } });
await authProvider.getIdentity(true);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants