Repository navigation
fix(s3): log a missing object as a warning, not an error - #96
Merged
Merged
Conversation
getFileBuffer/getFileStream logged "Failed to get file ..." at error level with a stack for every NoSuchKey/404. Callers that probe for optional files (e.g. a stored take that may not exist yet) treat that as a normal answer, so each probe produced an error entry. A missing key now logs one warning line; real failures still log as errors, and the thrown "S3 error: ..." message is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTicqgTde92c75hERgg3v
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
S3Service.getFileBuffer/getFileStreamloggedFailed to get file ...at error level, with a stack, for every missing key (NoSuchKey,NotFound, HTTP 404, "Key not found").Callers that probe for optional files treat a missing key as a normal answer (they catch it and return
null), yet every probe still produced an error entry. In production this was ~1,300 error entries in five days from one audio pipeline.Change
File not found <bucket>/<key>), no stack.S3 error: <message>is unchanged, so existing callers that match on it keep working.Tests
yarn jest utils/s3: three new cases (NoSuchKey, 404 on stream, real failure still an error).No consumer action needed after a submodule bump.
Generated by Claude Code