Repository navigation
Refactor: tidy foreignKey util, narrow any in validators - #95
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTicrQTzEeoiZ5N4vLecC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Small refactor, no behavior or public API change, no endpoint changes. No new utilities. No CONSUMER_CHANGES.md row needed (no consumer action).
utils/entity/foreignKey.util.ts: replace tsc-downleveledObject.assign(Object.assign({}, a), b)and=== null || === void 0 ? void 0 :with spread and?.(identical semantics).utils/validation/is-unique-date-range.ts,max-count-by-user-limit.ts: replaceanyonargs.objectand where-filters withRecord<string, any>/FindOptionsWhere<ObjectLiteral>.Audit findings (nothing else worth changing)
tsc --noUnusedLocals: no unused locals/imports; only unused params, all overridable hooks/interceptor signatures (public API, left alone).anyare mostly intentional (generic repos, TypeORM column types, test harness).Tests
tsc --noEmit: clean.jest: 860 pass, 25 fail in 5 suites (get-selected-ids,real-data-source,scenario-runner,yemot-replay.e2e,yemot-router.e2e). Identical failures on untouchedmainbaseline: they need the<app>/server/sharedlayout (CI checks out that way), not caused by this change.Generated by Claude Code