Skip to content

Refactor: tidy foreignKey util, narrow any in validators - #95

Merged
buzz-code merged 1 commit into
mainfrom
claude/refactor-debt-2026-11-07
Nov 8, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/refactor-debt-2026-11-07

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Scope

Small refactor, no behavior or public API change, no endpoint changes. No new utilities. No CONSUMER_CHANGES.md row needed (no consumer action).

  • utils/entity/foreignKey.util.ts: replace tsc-downleveled Object.assign(Object.assign({}, a), b) and === null || === void 0 ? void 0 : with spread and ?. (identical semantics).
  • utils/validation/is-unique-date-range.ts, max-count-by-user-limit.ts: replace any on args.object and where-filters with Record<string, any> / FindOptionsWhere<ObjectLiteral>.

Audit findings (nothing else worth changing)

  • tsc --noUnusedLocals: no unused locals/imports; only unused params, all overridable hooks/interceptor signatures (public API, left alone).
  • No commented-out code found.
  • Remaining any are mostly intentional (generic repos, TypeORM column types, test harness).

Tests

  • tsc --noEmit: clean.
  • jest: 860 pass, 25 fail in 5 suites (get-selected-ids, real-data-source, scenario-runner, yemot-replay.e2e, yemot-router.e2e). Identical failures on untouched main baseline: they need the <app>/server/shared layout (CI checks out that way), not caused by this change.

Generated by Claude Code

@buzz-code
buzz-code merged commit 25cbac3 into main Nov 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants