Skip to content

refactor(yemot): remove unused v1 chain-based Yemot flow - #68

Merged
buzz-code merged 2 commits into
mainfrom
claude/relaxed-goldberg-ve519p
Oct 11, 2026
Merged

buzz-code merged 2 commits into
mainfrom
claude/relaxed-goldberg-ve519p

Conversation

@buzz-code

@buzz-code buzz-code commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Delete v1 Yemot flow: yemot.module.ts, yemot.service.ts, chain.interface.ts, yemot.util.ts, yemot.exception.ts + their specs.
  • Trim yemot.interface.ts to FormatString only (same path — react-admin-nestjs/server/src/reports/reportGenerator.ts imports it).
  • Add CONSUMER_CHANGES.md row: per-app action = confirm no imports of removed files + sync yemot-integration skill copy. Done in: react-admin-nestjs (chore: bump server/shared (v1 Yemot removed) + sync yemot-integration skill react-admin-nestjs#211). Other apps apply it on their next bump.

Why

No consumer wires v1. Checked react-admin-nestjs, event-management-nra, teacher-report-nra, student-report-nra, dnd-management-nra, form-call: all use v2 (BaseYemotHandlerService, registered by base-app.module.ts). Nothing in nra-server outside v1 itself imported these files.

Test plan

  • react-admin-nestjs with server/shared at this branch: tsc --noEmit clean, full jest 118 suites / 1125 tests pass.

Related: https://github.com/buzz-code/multi-repo-codespace/pull/30 (skill source).

🤖 Generated with Claude Code

https://claude.ai/code/session_01WhKqWQTBUpM1iambUHayry

No consumer wires the v1 YemotModule/YemotService/Chain; every app uses
v2 (BaseYemotHandlerService via base-app.module). Keep FormatString in
yemot.interface.ts since react-admin-nestjs imports it from that path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WhKqWQTBUpM1iambUHayry
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WhKqWQTBUpM1iambUHayry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants