Repository navigation
refactor(yemot): remove unused v1 chain-based Yemot flow - #68
Merged
Merged
Conversation
No consumer wires the v1 YemotModule/YemotService/Chain; every app uses v2 (BaseYemotHandlerService via base-app.module). Keep FormatString in yemot.interface.ts since react-admin-nestjs imports it from that path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WhKqWQTBUpM1iambUHayry
2 tasks done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WhKqWQTBUpM1iambUHayry
buzz-code
force-pushed
the
claude/relaxed-goldberg-ve519p
branch
from
October 11, 2026 20:35
a0931cf to
c95f8eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yemot.module.ts,yemot.service.ts,chain.interface.ts,yemot.util.ts,yemot.exception.ts+ their specs.yemot.interface.tstoFormatStringonly (same path —react-admin-nestjs/server/src/reports/reportGenerator.tsimports it).CONSUMER_CHANGES.mdrow: per-app action = confirm no imports of removed files + syncyemot-integrationskill copy.Done in: react-admin-nestjs (chore: bump server/shared (v1 Yemot removed) + sync yemot-integration skill react-admin-nestjs#211). Other apps apply it on their next bump.Why
No consumer wires v1. Checked react-admin-nestjs, event-management-nra, teacher-report-nra, student-report-nra, dnd-management-nra, form-call: all use v2 (
BaseYemotHandlerService, registered bybase-app.module.ts). Nothing in nra-server outside v1 itself imported these files.Test plan
server/sharedat this branch:tsc --noEmitclean, fulljest118 suites / 1125 tests pass.Related: https://github.com/buzz-code/multi-repo-codespace/pull/30 (skill source).
🤖 Generated with Claude Code
https://claude.ai/code/session_01WhKqWQTBUpM1iambUHayry