Repository navigation
feat(i18n): localized message for a PDF that is too large to print - #80
Merged
Merged
Conversation
The server now answers a PDF print timeout with 413 and code PDF_PRINT_TIMEOUT. Map the code to a translation key like PDF_RENDER_BUSY, with Hebrew and English text, so the user sees a localized "narrow the filter or use Excel" message. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GTicqgTde92c75hERgg3v
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pairs with buzz-code/nra-server#97: a PDF that is too large to print now answers 413 with code
PDF_PRINT_TIMEOUT.Change
PDF_PRINT_TIMEOUTis added toERROR_CODE_TRANSLATION_KEYS(same mechanism asPDF_RENDER_BUSY) with Hebrew and English text underra.notification.pdf_print_timeout: narrow the filter (e.g. a shorter date range) or download as Excel.Without this change the user still sees the server's Hebrew fallback message, so the two PRs can merge in either order.
Tests
yarn jest utils/__tests__/httpUtil.test.js providers/__tests__/i18nProvider.test.js: code mapping and both locales.Generated by Claude Code