Skip to content

avoid force layout/reflow in moveBar #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hengwoon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avoid force layout/reflow in moveBar #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions simple-scrollbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
});

function drag(e) {
var delta = e.pageY - lastPageY;
lastPageY = e.pageY;

raf(function() {
var delta = e.pageY - lastPageY;
lastPageY = e.pageY;

context.el.scrollTop += delta / context.scrollRatio;
});
}
Expand Down Expand Up @@ -100,7 +100,7 @@
w.removeEventListener('resize', this.mB);
this.el.removeEventListener('scroll', this.mB);
this.el.removeEventListener('mouseenter', this.mB);

this.target.classList.remove('ss-container');

//Unwrap the initial content and remove remaining wrappers
Expand All @@ -115,18 +115,19 @@

ss.prototype = {
moveBar: function(e) {
var totalHeight = this.el.scrollHeight,
ownHeight = this.el.clientHeight,
_this = this;
var _this = this;

this.scrollRatio = ownHeight / totalHeight;
raf(function() {
var totalHeight = _this.el.scrollHeight,
ownHeight = _this.el.clientHeight,

var isRtl = _this.direction === 'rtl';
var right = isRtl ?
(_this.target.clientWidth - _this.bar.clientWidth + 18) :
(_this.target.clientWidth - _this.bar.clientWidth) * -1;
_this.scrollRatio = ownHeight / totalHeight;

var isRtl = _this.direction === 'rtl';
var right = isRtl ?
(_this.target.clientWidth - _this.bar.clientWidth + 18) :
(_this.target.clientWidth - _this.bar.clientWidth) * -1;

raf(function() {
// Hide scrollbar if no scrolling is possible
if(_this.scrollRatio >= 1) {
_this.bar.classList.add('ss-hidden')
Expand Down