Skip to content

modal examples#10

Merged
Asharee merged 5 commits into
mainfrom
asharee/modal-dialogs
May 22, 2026
Merged

modal examples#10
Asharee merged 5 commits into
mainfrom
asharee/modal-dialogs

Conversation

@Asharee
Copy link
Copy Markdown
Contributor

@Asharee Asharee commented May 6, 2026

Modal dialog examples!

@Asharee Asharee requested a review from smonette May 6, 2026 22:43
@Asharee Asharee changed the title modal-scroll.html example modal examples May 6, 2026
Copy link
Copy Markdown

@smonette smonette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asharee This is a great start! Couple request though

Comment thread html/modal-scroll.html Outdated
Comment thread html/modal-scroll.html Outdated
Comment thread html/modal-scroll.html
@Asharee Asharee requested a review from smonette May 13, 2026 17:09
Comment thread html/modal-scroll.html Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repeated
s looks a bit messy for an example. (Maybe I'm being too picky)

Could you flow some text and placeholder images instead? Maybe something along the lines of:

"Scroll down to see the modal. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur consectetur ligula convallis sodales accumsan. Integer non mattis augue. Nam elementum arcu imperdiet tortor fringilla, egestas vulputate dui euismod. Vivamus viverra metus at leo vulputate, nec sodales metus finibus. Vivamus in scelerisque velit. Nullam tempor blandit nibh, et blandit risus euismod in. Vivamus magna nibh, pellentesque et sagittis quis, consectetur a nibh. Curabitur varius diam id justo luctus, eu cursus tortor faucibus. Sed suscipit iaculis sodales."

Also, if you need placeholder images: https://placecats.com/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a fun poem and cat pics as place holder text and images (I thought this would be a bit cuter). I can make the text lorem ipsum if you don't think the poem is appropriate here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont love that you're submitting PRs on your sick day.

But Polly and Louie are pretty adorable, so its fine 😅

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

added placeholder text and images
@Asharee Asharee requested a review from smonette May 20, 2026 21:26
@smonette
Copy link
Copy Markdown

@Asharee This looks good! But there's one syntax error. Take a peek at the failing checker, and it'll show you what to change!

@Asharee Asharee requested a review from smonette May 21, 2026 22:59
Copy link
Copy Markdown

@smonette smonette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong work!!

@Asharee Asharee merged commit d8de3db into main May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants