Repository navigation
Put the ownership labels on Postgres pods - #126
Merged
Merged
Conversation
The pg instance pods have no bulbashenko.com/* labels, so the "Главное" dashboard cannot attribute their CPU and memory. CNPG copies inheritedMetadata onto the pods with a patch (ReconcileMetadata in v1.30.1), so this needs no restart and no maintenance window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90 together with bulbashenko-com/auth#20 (auth pods).
Adds
inheritedMetadata.labels(layer=app,app=data) to Clusterpg.No restart. The issue said "restarts Postgres", but in CNPG 1.30.1 (our operator version) labels from
inheritedMetadataare applied to running instance pods with a merge patch (pkg/reconciler/instance/metadata.go:ReconcileMetadata→updateClusterLabels→cli.Patch). No maintenance window is needed.Check after merge:
kubectl -n data get pods -l bulbashenko.com/app=data,cnpg.io/cluster=pg.🤖 Generated with Claude Code