[TE-6312] Remove nunit runner support#589
Merged
Merged
Conversation
nunit was implemented for a customer POC that didn't end up converting, and saw almost no real usage since. The custom runner covers this use case going forward, with selector-based splitting solving the namespace collision and result-path issues the nunit implementation had. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
nprizal
force-pushed
the
te-6312-remove-nunit-from-bktec
branch
from
4e38d80 to
2c26f66
Compare
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
I didn’t find any code issues in the removal itself. I’m leaving this as a comment rather than approving because it removes a customer-facing runner/CLI contract, which is above the approval ceiling for this review.
Want to dig deeper?
The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 3576, then answer my questions about the findings.
meghan-kradolfer
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
nunitwas added as an experimental runner, but it's seen almost no real usage. Looking at test plan records over the last month, only one internal example pipeline still uses it. Same story aspytest-pants, so we're removing it for the same reason.It also had a couple of real bugs. The result path handling didn't work as expected since NUnit outputs multiple XML files per test class, and we only matched on bare class name (not namespaced), so two test classes with the same name in different namespaces would get treated as one.
Given the near-zero usage and the known bugs, we're removing
nunitnow rather than fixing it.Context
pytest-pantsfor the same reasonTesting
go build ./...,go vet ./..., andgofmt -l .are all cleanTestGotestRun) is a pre-existing Go toolchain version mismatch in this environment, unrelated to this change (confirmed it fails the same way onmain)