Preserve failed tool calls across adapters#12
Open
ShuzhaoFeng wants to merge 1 commit into
Open
Conversation
Owner
|
Hey @ShuzhaoFeng! Thanks for your contribution and the note. I will test this when I get a chance and hopefully merge your changes soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent tool calls sometimes fail. When they are failed, the tool result is not applied and the harness often have special visual cues for them.
Harnesses report their tool result in their conversation:
patch_apply_end, which contains thesuccessattribute.tool_result.is_errortoolFormerData.status == "error"This PR addresses the error handling, and make sure the right type of tool call result is migrated.
P.S. Thank you for building this. We were working on another project which requires handing different agent conversations, and as a result we've built our own specialized tool for parsing them. Would have saved a lot of time if agent-migrator were already there. If this goes well, we'll open more PRs to transfer our knowledge into this public repo.