add support for generate --config - #436
Open
masariello wants to merge 1 commit into
Open
Conversation
pkwarren
reviewed
Jul 16, 2026
pkwarren
left a comment
pkwarren
left a comment
Member
There was a problem hiding this comment.
The changes look good but we should add a test to GenerateTest. See LintTest for some examples of config override tests.
The test should be written such that it would fail (or the results would differ) when buf generate is run with the default config vs. an override config.
| internal abstract val outputDirectory: Property<File> | ||
|
|
||
| /** The input buf configuration file. */ | ||
| @get:InputFiles |
Member
There was a problem hiding this comment.
Suggested change
| @get:InputFiles | |
| @get:InputFile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds support for the --config option of the generate command