Skip to content

Updated DeserializePush to use the URI parts Buckaroo uses to create a Push message#71

Open
robvangeloven wants to merge 1 commit intobuckaroo-it:masterfrom
robvangeloven:master
Open

Updated DeserializePush to use the URI parts Buckaroo uses to create a Push message#71
robvangeloven wants to merge 1 commit intobuckaroo-it:masterfrom
robvangeloven:master

Conversation

@robvangeloven
Copy link
Copy Markdown

I noticed that the documentation isn't super clear in what the request URI should be when deserializing a message, this change updates the PushHandler so there's no more guessing from the users of the SDK what the correct format should be for the URI

Copy link
Copy Markdown
Collaborator

I found one review item here.

This change updates the public PushHandler.DeserializePush(...) signature from string requestUri to Uri requestUri. The new behavior may be correct for the Buckaroo signature calculation, but removing the old overload makes this a source-breaking API change for existing SDK consumers.

If the goal is to make URI handling less ambiguous, I’d recommend keeping the old string overload and forwarding it to the new implementation so callers don’t get a compile-time break from what otherwise looks like a bugfix PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants