Fix/clean up solution: warnings & .NET 4.8#49
Open
timvandenhof wants to merge 37 commits intobuckaroo-it:masterfrom
Open
Fix/clean up solution: warnings & .NET 4.8#49timvandenhof wants to merge 37 commits intobuckaroo-it:masterfrom
timvandenhof wants to merge 37 commits intobuckaroo-it:masterfrom
Conversation
…' can be converted to a method as its get accessor is never invoked.
…DataRequest' can be removed as the value assigned to it is never read
…can be removed as the value assigned to it is never read
…ion' can be removed as the value assigned to it is never read
…of a shipped public API ==> Marked obsolete, added new constructor
…t' can be converted to a method as its get accessor is never invoked.
…dInfo(TransactionRefundInfoBase)' is obsolete: 'Parameter transactionRefundInfoBase is no longer needed.'
…king change, removes 4 year obsolete implementation
Collaborator
|
One cleanup item to address before merge: this PR still includes That file is editor-local state and will create machine-specific noise in the repo. I’d recommend removing it from the PR so the cleanup stays focused on intentional source changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Was not able to run tests, see issue #48 .